Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "bot" icon #978

Closed
gnprice opened this issue Oct 2, 2024 · 6 comments · Fixed by #986
Closed

Update "bot" icon #978

gnprice opened this issue Oct 2, 2024 · 6 comments · Fixed by #986
Assignees
@fombalang
Labels
a-design Visual and UX design
Milestone
Beta 4: Fall 2024

Comments

@gnprice
Copy link
Member

gnprice commented Oct 2, 2024

When a message was sent by a bot, we put an icon by the sender's name to indicate it's a bot.

In the web app the icon we use was recently redesigned:

to a friendlier-looking "bot" face with one antenna instead of two antennas. We should update to the new one-antenna icon.

Reported by @alexmv in chat: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Bot.20icon.20asset.20needs.20update/near/1953361
@gnprice gnprice added the a-design Visual and UX design label Oct 2, 2024
@gnprice gnprice added this to the Beta 4: Fall 2024 milestone Oct 2, 2024
@fombalang
Copy link
Contributor

Hi @gnprice
I would like to work on this issue, please.

@gnprice
Copy link
Member Author

gnprice commented Oct 3, 2024

Sure, please go ahead.

@fombalang
Copy link
Contributor

Alright!

@fombalang
Copy link
Contributor

Hello
I have updated the bot icon.

Screenshot_20241004-085226

Screenshot_20241004-085217

Before I send a PR for this, I would like to verify if a change like this would require that tests be made or updated? Seeing as I only updated the icon SVG file and ran the tools/icons/build-icon-font command without changing any Dart code?

Thank you

@gnprice
Copy link
Member Author

gnprice commented Oct 4, 2024

Cool ­— please go ahead and send the PR. This change will be fine without tests.

In general if you have a change that you think may not need tests, I recommend sending the PR without tests but then calling that question out clearly in the PR description. That helps speed things along if reviewers agree that tests aren't needed. It also means reviewers can see the rest of your changes, which can help answer the question of whether tests are needed.

@fombalang
Copy link
Contributor

Okay, Understood

@fombalang fombalang mentioned this issue Oct 5, 2024
Merged
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Oct 11, 2024
@fombalang
icons: Update bot icon with single antenna version
ec6cddc 
Icon gotten from the Github Zulip repository at
https://github.com/zulip/zulip/
blob/030f93595/web/shared/icons/bot.svg

Fixes: zulip#978
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Oct 11, 2024
@fombalang
icons: Update bot icon with single antenna version
ce1ecf9 
Icon gotten from the Github Zulip repository at
https://github.com/zulip/zulip/blob/030f93595/web/shared/icons/bot.svg

Fixes: zulip#978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fombalang fombalang

Labels
a-design Visual and UX design
Projects
Flutter app
Status: Done
Milestone
Beta 4: Fall 2024
Development

Successfully merging a pull request may close this issue.

icons: Updated bot icon with single antenna version. fombalang/zulip-flutter
2 participants
@gnprice @fombalang