macOS: Fix undo redo not working on macOS. #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Can't test this though as I don't have a mac. |
|
electron/electron#15728 was reported with Electron 3. Did you confirm that this is still an issue with Electron 8? |
The default API provided by Electron doesn't work as expected. More info here - electron/electron#15728 Fixes: #866.
@andersk yeah, it's still broken. Let's merge? |
andersk
reviewed
Mar 5, 2020
|
@andersk made some changes. |
|
I think the undo-redo issue is being solved. If there is any remaining work @akashnimare please share it with me. |
|
@adityamudgil2505 can you get the Electron issue (electron/electron#15728) reopened or maybe open a new one since it still doesn't work on v8? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default API provided by Electron doesn't work
as expected. More info here -
electron/electron#15728
Fixes: #866.
What's this PR do?
Any background context you want to provide?
Screenshots?
You have tested this PR on: