Fixed:Broken image icon in left sidebar and typo in classname #630
Conversation
|
Hello @NikhilPhalange, thanks for working on this. |
|
Thanks @abhigyank for the suggestion. I have changed the code and it shows the initial letter of the organisation's name now. I hope it is fine. In case of any issues, please inform me. |
|
@abhigyank Thanks for the suggestions. I have incorporated all of them. Please let me know if there are any more issues. Also, I want to work on other issues, so can you approve this PR or should I work without claiming(I can't claim any other issue while I am assigned one)? |
app/renderer/css/main.css
Outdated
| margin-left: 17%; | ||
| border-radius: 4px; | ||
| } | ||
| content: attr(data-content); |
There was a problem hiding this comment.
@NikhilPhalange You forgot to remove the parts of your code that was replaced.
There was a problem hiding this comment.
@abhigyank Thanks a lot, I was incorporating the suggested changes for the first time, never did it before. Didn't know how it worked. Please inform me in case anything is left.
|
Looks good @NikhilPhalange. Could you squash the commits into one commit? |
|
@abhigyank I have squashed them in one commit, you can merge the PR now. Thanks a lot. |
|
@abhigyank What needs to be changed-the main summary 'Fixed:Broken..... in classname' or the long message due to squashing? |
|
Yes both. See Zulip's commit message guidelines - https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages |
Broken image icon was shown for a few seconds before realm character icon replaced it. This replaces the broken image icon by realm character in alt attribute. This fixes zulip#630.
|
@abhigyank The commit message is fixed. Thanks a lot for the guidance. I will make sure I adhere to these in my subsequent contributions. |
Broken image icon was shown for a few seconds before realm character icon replaced it. This replaces the broken image icon by realm character in alt attribute. This fixes zulip#630.
|
@abhigyank Can you please tell me why the PR is not merged yet? Is it because it has not been tested on Ubuntu and OS, just curious to know the process? |
|
It'll be merged once @akashnimare reviews it. He is currently recovering from surgery and busy with the release of the next update and probably hence the delay. |
What's this PR do?
The initial letter of Organistaion's name is shown instead of broken image when the app starts and typing mistake in main.js file in classname is fixed.
You have tested this PR on: