Changed saveServerIcon() to not use request() on defaultIconUrl #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhigyank
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
@akashnimare This looks good to me and works as expected, could be merged.
Though the issue itself is not much of a problem to us now cause we fallback to the initial character of the realm, but this would now correctly prevent the error from propping up.
3 tasks
|
I made a mistake while squashing the commits together, so this is 2 commits instead of 1. I hope this is fine. @akashnimare Could you review this? |
context-menu: Fix context menu indexing. Addresses a problem where the context menu would get the incorrect index of server in sidebar and cause a crash when attempting to remove the server. Add comment justifying extra index parameter.
|
Please discard this. I will open up a new PR. |
This reverts commit dd1ce9c.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Fixes https://github.com/zulip/zulip-electron/issues/533
Any background context you want to provide?
Screenshots?
You have tested this PR on: