Skip to content

Add ForwardButton to Sidebar #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tarun8718
Copy link
Contributor

Signed-off-by: tarun8718 tarunkumar8718@gmail.com


What's this PR do:
Adds Forward Button to the sidebar.

Screenshots
ForwardButton

You have tested this PR on:

  • Windows
  • Linux/Ubuntu
  • macOS

Signed-off-by: tarun8718 <tarunkumar8718@gmail.com>
@octogonz
Copy link

octogonz commented Feb 5, 2021

Nice!

@tarun8718
Copy link
Contributor Author

@andersk could you please review this?

@andersk
Copy link
Member

andersk commented Mar 10, 2021

My first question is, why is this functionality so important as to justify taking away space on the sidebar that could be used for more organizations? Can you explain the use case?

@octogonz
Copy link

As a new user, it took me a while to realize that the -> command existed at all. It is not found next to the <- button. It is under the History menu (where the <- command has a different name "Back"). Working in a public OSS forum where the majority of our participants are using Zulip for the first time, I can say that Zulip is not very intuitive for new users. So if something is counterintuitive for myself after months of using Zulip, it's likely that new users would also be confused by this.

BTW the desktop app for Slack has both <- and -> buttons. They solve the problem you mentioned by putting their buttons in the title bar:

Capture

@zulipbot
Copy link
Member

Heads up @tarun8718, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants