-
-
Notifications
You must be signed in to change notification settings - Fork 392
Fix bridge_with_irc #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bridge_with_irc #469
Conversation
Hello @rht, it seems like you have referenced #106 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged. Please run An example of a correctly-formatted commit:
Thank you for your contributions to Zulip! |
A test bridge between |
d1be3b4
to
11d9a14
Compare
One more test bridge with |
9f7c1a8
to
df1f94a
Compare
is_a_stream = msg["type"] == "stream" | ||
if is_a_stream: | ||
in_the_specified_stream = msg["display_recipient"] == self.stream | ||
at_the_specified_subject = msg["subject"] == self.topic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
topic comparisons in Zulip should be case-insensitive, can you fix this comparison?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed via casefold()
method, which handles unicode chars additionally instead of just lower()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In zulip/zulip:
zerver/lib/topic.py
156: canonical_name = topic_name.lower()
This should have been casefold()
as well.
I merged most of this, and posted a comment (which impacts the last few commits in a small way). |
Looks great, merged, thanks @rht! |
This fixes #106.
Can be tested with
Note the
--stream
arg is added here.