Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to use mysql cookbook version ~> 6.0 #21

Merged
merged 5 commits into from
Apr 9, 2015

Conversation

avsh
Copy link
Contributor

@avsh avsh commented Mar 26, 2015

No description provided.

@zuazo
Copy link
Owner

zuazo commented Mar 29, 2015

@avsh, thanks for the PR! LGTM 😃

Please, can you document the new attributes in the README and the metadata? The usage section also needs to be updated.

@zuazo zuazo self-assigned this Mar 29, 2015
@avsh
Copy link
Contributor Author

avsh commented Apr 3, 2015

@zuazo, I documented changes! Please, review

@zuazo
Copy link
Owner

zuazo commented Apr 3, 2015

Thanks @avsh. Give me a couple of days to test this carefully.

@zuazo
Copy link
Owner

zuazo commented Apr 3, 2015

Sorry for not having realized before, could you please move the dbinstance, dbversion and dbrootpassword attributes to the database namespace? That's because the config namespace is used to populate the owncloud config.php configuration file.

I mean something like the following:

  • node['owncloud']['database']['instance']
  • node['owncloud']['database']['version']
  • node['owncloud']['database']['rootpassword']

Thanks again for all your work 😉

@avsh
Copy link
Contributor Author

avsh commented Apr 3, 2015

@zuazo, done

Tested against mysql, postgresql ubuntu 14.04

@zuazo
Copy link
Owner

zuazo commented Apr 9, 2015

@avsh, I'm going to merge this. Seems not to break anything. Thanks!

zuazo added a commit that referenced this pull request Apr 9, 2015
upgrade to use mysql cookbook version ~> 6.0
@zuazo zuazo merged commit 9bed9a5 into zuazo:master Apr 9, 2015
@zuazo
Copy link
Owner

zuazo commented Oct 7, 2015

Feature released in 1.0.0.

@avsh avsh deleted the use-mysql-6-cookbook branch October 8, 2015 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants