Skip to content

Conversation

@DCKT
Copy link
Contributor

@DCKT DCKT commented Feb 17, 2024

Hi !

I found out Response.json method was missing and misleading (vs response.json()).
I made the choice to not restrict the type for a better usage as you can pass a JS object.
I also updated the example to reflect more the use case.

Cheers

@zth
Copy link
Owner

zth commented Feb 18, 2024

@DCKT awesome, thank you!

I wonder if we should have a dedicated version taking a JSON.t though, and then have this here too but prepend it with "unsafe" or similar. What do you think?

@DCKT
Copy link
Contributor Author

DCKT commented Feb 18, 2024 via email

@zth
Copy link
Owner

zth commented Feb 19, 2024

@DCKT great stuff! Please add an entry to the changelog as well. Also, thanks for the PRs, keep them coming! 😄

@zth zth merged commit 1c9770e into zth:main Feb 19, 2024
This was referenced Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants