'main': Highlight the ! precommand as an error when not at the start of a pipeline. #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phy1729
requested changes
Oct 23, 2018
| case $res in | ||
| reserved) # reserved word | ||
| style=reserved-word | ||
| if [[ $arg == '!' && $this_word != *':start_of_pipeline:'* ]]; then |
There was a problem hiding this comment.
Why not put this in the case statement following?
| style=assign | ||
| in_array_assignment=false | ||
| next_word+=':start:' | ||
| next_word+=':start::start_of_pipeline:' |
There was a problem hiding this comment.
foo=(bar) ! false is a parse error here, so I think this is incorrect.
… a pipeline. Fixes zsh-users#511.
danielshahaf
force-pushed
the
i511-bang-pipeline
branch
from
4282cd7 to
44b89f3
Compare
|
Added tests and addressed the comments. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #511.