Skip to content

Commit

Permalink
Don't highlight backslash-escaped brackets
Browse files Browse the repository at this point in the history
  • Loading branch information
rolandwalker committed Nov 7, 2020
1 parent 1715f39 commit 4662324
Show file tree
Hide file tree
Showing 2 changed files with 64 additions and 4 deletions.
18 changes: 14 additions & 4 deletions highlighters/brackets/brackets-highlighter.zsh
Original file line number Diff line number Diff line change
Expand Up @@ -47,20 +47,29 @@ _zsh_highlight_highlighter_brackets_predicate()
_zsh_highlight_highlighter_brackets_paint()
{
local char style
local -i bracket_color_size=${#ZSH_HIGHLIGHT_STYLES[(I)bracket-level-*]} buflen=${#BUFFER} level=0 matchingpos pos
local -i bracket_color_size=${#ZSH_HIGHLIGHT_STYLES[(I)bracket-level-*]} buflen=${#BUFFER} level=0 matchingpos pos escaped_state
local -A levelpos lastoflevel matching

# Find all brackets and remember which one is matching
pos=0
escaped_state=0
for char in ${(s..)BUFFER} ; do
(( ++pos ))
if [[ $char = "\\" ]]; then
(( escaped_state = !escaped_state ))
continue
fi
case $char in
["([{"])
levelpos[$pos]=$((++level))
lastoflevel[$level]=$pos
if (( ! escaped_state )); then
levelpos[$pos]=$((++level))
lastoflevel[$level]=$pos
fi
;;
[")]}"])
if (( level > 0 )); then
if (( escaped_state )); then
:
elif (( level > 0 )); then
matchingpos=$lastoflevel[$level]
levelpos[$pos]=$((level--))
if _zsh_highlight_brackets_match $matchingpos $pos; then
Expand All @@ -72,6 +81,7 @@ _zsh_highlight_highlighter_brackets_paint()
fi
;;
esac
escaped_state=0
done

# Now highlight all found brackets
Expand Down
50 changes: 50 additions & 0 deletions highlighters/brackets/test-data/escaped-brackets.zsh
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
#!/usr/bin/env zsh
# -------------------------------------------------------------------------------------------------
# Copyright (c) 2020 zsh-syntax-highlighting contributors
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without modification, are permitted
# provided that the following conditions are met:
#
# * Redistributions of source code must retain the above copyright notice, this list of conditions
# and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright notice, this list of
# conditions and the following disclaimer in the documentation and/or other materials provided
# with the distribution.
# * Neither the name of the zsh-syntax-highlighting contributors nor the names of its contributors
# may be used to endorse or promote products derived from this software without specific prior
# written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR
# IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
# FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER
# IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
# OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
# -------------------------------------------------------------------------------------------------
# -*- mode: zsh; sh-indentation: 2; indent-tabs-mode: nil; sh-basic-offset: 2; -*-
# vim: ft=zsh sw=2 ts=2 et
# -------------------------------------------------------------------------------------------------

unsorted=1

ZSH_HIGHLIGHT_STYLES[bracket-level-1]=
ZSH_HIGHLIGHT_STYLES[bracket-level-2]=
ZSH_HIGHLIGHT_STYLES[bracket-level-3]=
# expect no matchingbracket highlight
ZSH_HIGHLIGHT_STYLES[cursor-matchingbracket]=

CURSOR=9 # cursor is zero-based

BUFFER=$'if [[ "\\]" =~ "[\\)\\}\\]]" ]]; then echo true; fi'

expected_region_highlight=(
'23 23 bracket-level-3' # ]
'4 4 bracket-level-1' # [
'5 5 bracket-level-2' # [
'26 26 bracket-level-2' # ]
'27 27 bracket-level-1' # ]
'16 16 bracket-level-3' # [
)

0 comments on commit 4662324

Please sign in to comment.