Skip to content

WIP: completion for pytest #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 7, 2016

This is WIP that needs to be cleaned up.

Inspired/based on https://github.com/alfredodeza/zsh-plugins/blob/master/pytest/pytest.plugin.zsh.

TODO:

@syohex
Copy link
Contributor

syohex commented Oct 8, 2016

Did you read https://github.com/zsh-users/zsh-completions#contributing ?

Completions are not accepted when already available in their original project.

I suppose you should commit to original repository.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 8, 2016

There is no completion shipped with pytest already, but we might (pytest-dev/pytest#1992).
In general I find it more convenient to have it automatically installed by using this repo.
I could also imagine adding it to Zsh itself, but that then needs time to trickle down to users not using the latest.

@nicoulaj
Copy link
Member

I guess since they don't really have a zsh compdef in their project, we can have it here.

However we don't merge partial work, people tend to just forget about it after they add it here.

@nicoulaj nicoulaj closed this Oct 16, 2016
@blueyed
Copy link
Contributor Author

blueyed commented Oct 16, 2016

Yeah, will reopen then (I've marked it as "WIP" to keep it on the radar, but can see that you rather have the PR queue empty).

For people finding this: I am using this myself, it works good, but needs to get cleaned up for submission here.

@blueyed
Copy link
Contributor Author

blueyed commented Nov 13, 2018

@nicoulaj
Sure, although that contradicts your previous comment.

But I think it is rather complete already in general, and TODOs can be addressed always later.

I've pushed a fixup with my current version (please squash-merge in case you want to take it already).

@blueyed
Copy link
Contributor Author

blueyed commented Nov 13, 2018

Hmm, seems to not show up due to the PR being closed?!
The branch is here: https://github.com/blueyed/zsh-completions/tree/pytest

Added to my dotfiles now: blueyed/oh-my-zsh@fd89b19 (2020-03-01)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants