Handling of logging affects logging external to package

[Tonyynot14]

Description
Logging setup if not enabled disables information logging for all other loggers. This affects scripts that use this package

Reproduction
Import this package and setup your own logger with a custom name. Then try to log information alerts after initialize the ziaclient

Expected behavior
Logging inside of the module to not affect logging outside of it. Logging for the package should be able to be completely turned off.

Is it a regression?
No

Other Information

• Windows

Additional context
The is mainly related to how logging is being handled in the script. This can most likely be resolved by setting the level desired for the sdk logging to the level needed and not

logging.disable(logging.INFO) # This affects named loggers as well 

[willguibr]

@Tonyynot14 Please indicate which exact version of this SDK you're currently using, as well as provide example of what you're attempting to accomplish.

The SDK currently provides detailed debug mode that can be enabled via configuration setter

config = {
    "logging": {"enabled": False, "verbose": False},
}

or via environment variables

export ZSCALER_SDK_LOG=true
export ZSCALER_SDK_VERBOSE=true

Zscaler DevRel.

[Tonyynot14]

zscaler-sdk-python 1.2.4

from zscaler.oneapi_client import LegacyZIAClient
import logging

FULL_LOGGING = logging.getLogger('full_logger')
FULL_LOGGING.setLevel(logging.INFO)
stream_handler = logging.StreamHandler()
stream_handler.setLevel(logging.INFO)
log_formatter = logging.Formatter('%(asctime)s\t%(levelname)s\t%(message)s', datefmt = '%Y-%m-%d %H:%M:%S')
stream_handler.setFormatter(log_formatter)
file_handler = logging.FileHandler("zscaler_automation.log")
file_handler.setLevel(logging.INFO)
file_handler.setFormatter(log_formatter)


FULL_LOGGING.addHandler(file_handler)
FULL_LOGGING.addHandler(stream_handler)


config = {
    "username": '{yourUsername}',
    "password": '{yourPassword}',
    "api_key": '{yourApiKey}',
    "cloud": '{yourCloud}',
    "logging": {"enabled": False, "verbose": False},
}

def main():
    with LegacyZIAClient(config) as client:
        FULL_LOGGING.info("TESTING LOGGER ")
        users, _, _ = client.zia.user_management.list_users()

        


if __name__ == "__main__":
    main()

logging.py file setup_logging function declaration.

    if not enabled:
        # If logging is not enabled, set up a null handler
        logging.disable(logging.INFO)
        return

The problem with this is that it disables info logging for the root logger and all other loggers created.

[willguibr]

@Tonyynot14 Please upgrade to version v1.4.2 and let us know if it addresses your problem

Zscaler DevRel

[willguibr]

No feedback provided for the past 3 weeks so closing the issue.
If further issues arise, please raise a new GitHub issue or contact Zscaler Global Support.

Zscaler DevRel