Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) zia_dlp_dictionary empty phrases block #221

Merged
merged 5 commits into from
Apr 29, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updated Changelog and release-notes
  • Loading branch information
willguibr committed Apr 29, 2023
commit d22865d8f3db00b8bafa2a7de2f9c28e25b74660
15 changes: 8 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
# Changelog

## 2.5.2 (April, 28 2023)
## 2.5.2 (May, 1 2023)

### Notes

- Release date: **(April, 28 2023)**
- Release date: **(May, 1 2023)**
- Supported Terraform version: **v1.x**

### Fixes

- [PR #219](https://github.com/zscaler/terraform-provider-zia/pull/219) ``zia_dlp_web_rules``: Fixed drift issues with attributes ``url_categories`` and ``dlp_engines``
- [PR #221](https://github.com/zscaler/terraform-provider-zia/pull/221) ``zia_dlp_dictionary``: Fix DLP dictionary resource when ``phrase`` attribute is not provided

### Ehancements

- [PR #224](https://github.com/zscaler/terraform-provider-zia/pull/224) ``zia_dlp_web_rule``: Reduced TimeTicker for faster rule order processing during creation and modifications.
- [PR #224](https://github.com/zscaler/terraform-provider-zia/pull/224) ``zia_dlp_web_rule``: Updated DLP Web Rule documentation with more examples
- [PR #226](https://github.com/zscaler/terraform-provider-zia/pull/226) Expanded ZIA search criteria to include auditor users.
- [PR #227](https://github.com/zscaler/terraform-provider-zia/pull/227) Introduced new attribute ``parent_name`` to the resource ``zia_location_management``. The attribute will allow the ability to search for sublocation resources across multiple parent locations specially when overlapping names are in use. Issue [#223](https://github.com/zscaler/terraform-provider-zia/issues/223)

### Fixes

- [PR #219](https://github.com/zscaler/terraform-provider-zia/pull/219) ``zia_dlp_web_rules``: Fixed drift issues with attributes ``url_categories`` and ``dlp_engines``
- [PR #221](https://github.com/zscaler/terraform-provider-zia/pull/221) ``zia_dlp_dictionary``: Fix DLP dictionary resource when ``phrase`` attribute is not provided

## 2.5.1 (April, 12 2023)

Expand Down
13 changes: 10 additions & 3 deletions docs/guides/release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,24 @@ Track all ZIA Terraform provider's releases. New resources, features, and bug fi

- Release date: **(April, 28 2023)**
- Supported Terraform version: **v1.x**
## 2.5.2 (May, 1 2023)

### Fixes
### Notes

- [PR #219](https://github.com/zscaler/terraform-provider-zia/pull/219) ``zia_dlp_web_rules``: Fixed drift issues with attributes ``url_categories`` and ``dlp_engines``
- [PR #221](https://github.com/zscaler/terraform-provider-zia/pull/221) ``zia_dlp_dictionary``: Fix DLP dictionary resource when ``phrase`` attribute is not provided
- Release date: **(May, 1 2023)**
- Supported Terraform version: **v1.x**

### Ehancements

- [PR #224](https://github.com/zscaler/terraform-provider-zia/pull/224) ``zia_dlp_web_rule``: Reduced TimeTicker for faster rule order processing during creation and modifications.
- [PR #224](https://github.com/zscaler/terraform-provider-zia/pull/224) ``zia_dlp_web_rule``: Updated DLP Web Rule documentation with more examples
- [PR #226](https://github.com/zscaler/terraform-provider-zia/pull/226) Expanded ZIA search criteria to include auditor users.
- [PR #227](https://github.com/zscaler/terraform-provider-zia/pull/227) Introduced new attribute ``parent_name`` to the resource ``zia_location_management``. The attribute will allow the ability to search for sublocation resources across multiple parent locations specially when overlapping names are in use. Issue [#223](https://github.com/zscaler/terraform-provider-zia/issues/223)

### Fixes

- [PR #219](https://github.com/zscaler/terraform-provider-zia/pull/219) ``zia_dlp_web_rules``: Fixed drift issues with attributes ``url_categories`` and ``dlp_engines``
- [PR #221](https://github.com/zscaler/terraform-provider-zia/pull/221) ``zia_dlp_dictionary``: Fix DLP dictionary resource when ``phrase`` attribute is not provided

## 2.5.1 (April, 12 2023)

Expand Down
4 changes: 1 addition & 3 deletions zia/resource_zia_dlp_web_rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,6 @@ func resourceDlpWebRules() *schema.Resource {
Computed: true,
Description: "Indicates whether a Zscaler Incident Receiver is associated to the DLP policy rule.",
},
// We need to ensure that no drifts are ocurring when the following attributes are set.
// Currently if items in a list i.e dlp_engines or url_categories are unordered a drift is caused as Terraform tries to re-arrange the objects at every run
"file_types": getDLPRuleFileTypes("The list of file types to which the DLP policy rule must be applied."),
"locations": listIDsSchemaTypeCustom(8, "The Name-ID pairs of locations to which the DLP policy rule must be applied."),
"location_groups": listIDsSchemaTypeCustom(32, "The Name-ID pairs of locations groups to which the DLP policy rule must be applied."),
Expand Down Expand Up @@ -472,7 +470,7 @@ func expandDlpWebRules(d *schema.ResourceData) dlp_web_rules.WebDLPRules {
Departments: expandIDNameExtensionsSet(d, "departments"),
Users: expandIDNameExtensionsSet(d, "users"),
URLCategories: expandSetIDsSchemaTypeCustom(d, "url_categories"),
DLPEngines: expandSetIDsSchemaTypeCustom(d, "dlp_engines"),
DLPEngines: expandIDNameExtensionsSet(d, "dlp_engines"),
TimeWindows: expandIDNameExtensionsSet(d, "time_windows"),
Labels: expandIDNameExtensionsSet(d, "labels"),
ExcludedUsers: expandIDNameExtensionsSet(d, "excluded_groups"),
Expand Down