Merge pull request #19 from willguibr/fix-setting-lastmodifiedby-issue

fix setting last modified by issue in url filtering rule resource
zscaler · Oct 21, 2021 · b0aa00f · b0aa00f
2 parents 31c93ad + 6f46cc6
commit b0aa00f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/zia/common.go b/zia/common.go
@@ -115,14 +115,13 @@ func flattenIDNameExtensions(list []common.IDNameExtensions) []interface{} {
 }
 
 func flattenLastModifiedBy(lastModifiedBy *common.IDNameExtensions) []interface{} {
-	lastModified := make([]interface{}, 1)
-	for lastModifiedBy != nil {
-		lastModified[0] = map[string]interface{}{
+	lastModified := make([]interface{}, 0)
+	if lastModifiedBy != nil {
+		lastModified = append(lastModified, map[string]interface{}{
 			"id":         lastModifiedBy.ID,
 			"name":       lastModifiedBy.Name,
 			"extensions": lastModifiedBy.Extensions,
-		}
+		})
 	}
-
 	return lastModified
 }
diff --git a/zia/data_source_zia_url_filtering_rules.go b/zia/data_source_zia_url_filtering_rules.go
@@ -294,7 +294,7 @@ func dataSourceURLFilteringRules() *schema.Resource {
 				Computed: true,
 			},
 			"last_modified_by": {
-				Type:     schema.TypeList,
+				Type:     schema.TypeSet,
 				Computed: true,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{