Fix: URL Filtering and FW Filtering validation (#168)

* Fix: URL Filtering and FW Filtering validation

* Updated Changelog and release-notes

CHANGELOG.md

@@ -1,5 +1,30 @@
 # Changelog
 
+## 2.3.4 (January, 4 2023)
+
+### Notes
+
+- Release date: **(January, 4 2023)**
+- Supported Terraform version: **v1.x**
+
+### Fixes
+
+- [PR #168](https://github.com/zscaler/terraform-provider-zia/pull/168) ``zia_firewall_filtering_rule`` Added the following new network applications to validation function
+  - ``VMWARE_HORIZON_VIEW``,``ADOBE_CREATIVE_CLOUD``, ``ZOOMINFO``, ``SERVICE_NOW``, ``MS_SSAS``, ``GOOGLE_DNS``, ``CLOUDFLARE_DNS``, ``ADGUARD``, ``QUAD9``, ``OPENDNS``, ``CLEANBROWSING``, ``COMCAST_DNS``, ``NEXTDNS``, ``POWERDNS``,``BLAHDNS``,``SECUREDNS``,``RUBYFISH``,``DOH_UNKNOWN``,``GOOGLE_KEEP``,``AMAZON_CHIME``,``WORKDAY``,``FIFA``,``ROBLOX``,``WANGWANG``,``S7COMM_PLUS``,``DOH``,``AGORA_IO``,``MS_DFSR``,``WS_DISCOVERY``,``STUN``,``FOLDINGATHOME``,``GE_PROCIFY``,``MOXA_ASPP``,``APP_CH``,``GLASSDOOR``,``TINDER``,``BAIDU_TIEBA``,``MIMEDIA``,``FILESANYWHERE``,``HOUSEPARTY``,``GBRIDGE``,``HAMACHI``,``HEXATECH``,``HOTSPOT_SHIELD``,``MEGAPROXY``,``OPERA_VPN``,``SPOTFLUX``,``TUNNELBEAR``,``ZENMATE``, ``OPENGW``, ``VPNOVERDNS``, ``HOXX_VPN``, ``VPN1_COM``, ``SPRINGTECH_VPN``, ``BARRACUDA_VPN``, ``HIDEMAN_VPN``, ``WINDSCRIBE``, ``BROWSEC_VPN``, ``EPIC_BROWSER_VPN``, ``SKYVPN``, ``KPN_TUNNEL``, ``ERSPAN``,``EVASIVE_PROTOCOL``, ``DOTDASH``, ``ADOBE_DOCUMENT_CLOUD``, ``FLIPKART_BOOKS``
+
+- [PR #165](https://github.com/zscaler/terraform-provider-zia/pull/162) ``zia_url_filtering_rules`` Added new URL Categories
+
+## 2.3.3 (January, 1 2023)
+
+### Notes
+
+- Release date: **(January, 1 2023)**
+- Supported Terraform version: **v1.x**
+
+### Fixes
+
+- [PR #167](https://github.com/zscaler/terraform-provider-zia/pull/167) Published provider as v2 go-module
+
 ## 2.3.2 (December, 30 2022)
 
 ### Notes

GNUmakefile

@@ -16,15 +16,15 @@ build: fmtcheck
 build13: GOOS=$(shell go env GOOS)
 build13: GOARCH=$(shell go env GOARCH)
 ifeq ($(OS),Windows_NT)  # is Windows_NT on XP, 2000, 7, Vista, 10...
-build13: DESTINATION=$(APPDATA)/terraform.d/plugins/$(ZIA_PROVIDER_NAMESPACE)/2.3.2/$(GOOS)_$(GOARCH)
+build13: DESTINATION=$(APPDATA)/terraform.d/plugins/$(ZIA_PROVIDER_NAMESPACE)/2.3.4/$(GOOS)_$(GOARCH)
 else
-build13: DESTINATION=$(HOME)/.terraform.d/plugins/$(ZIA_PROVIDER_NAMESPACE)/2.3.2/$(GOOS)_$(GOARCH)
+build13: DESTINATION=$(HOME)/.terraform.d/plugins/$(ZIA_PROVIDER_NAMESPACE)/2.3.4/$(GOOS)_$(GOARCH)
 endif
 build13: fmtcheck
 	go mod tidy && go mod vendor
 	@echo "==> Installing plugin to $(DESTINATION)"
 	@mkdir -p $(DESTINATION)
-	go build -o $(DESTINATION)/terraform-provider-zia_v2.3.2
+	go build -o $(DESTINATION)/terraform-provider-zia_v2.3.4
 
 test: fmtcheck
 	go test $(TEST) || exit 1

docs/guides/release-notes.md

@@ -12,10 +12,30 @@ description: |-
 Track all ZIA Terraform provider's releases. New resources, features, and bug fixes will be tracked here.
 
 ---
-``Last updated: v2.3.2``
+``Last updated: v2.3.4``
 
 ---
 
+## 2.3.4 (January, 4 2023)
+
+### Notes
+
+- Release date: **(January, 4 2023)**
+- Supported Terraform version: **v1.x**
+
+### Fixes
+
+- [PR #168](https://github.com/zscaler/terraform-provider-zia/pull/168) ``zia_firewall_filtering_rule`` Added the following new network applications to validation function
+  - ``VMWARE_HORIZON_VIEW``,``ADOBE_CREATIVE_CLOUD``, ``ZOOMINFO``, ``SERVICE_NOW``, ``MS_SSAS``, ``GOOGLE_DNS``, ``CLOUDFLARE_DNS``, ``ADGUARD``, ``QUAD9``, ``OPENDNS``, ``CLEANBROWSING``, ``COMCAST_DNS``, ``NEXTDNS``, ``POWERDNS``,``BLAHDNS``,``SECUREDNS``,``RUBYFISH``,``DOH_UNKNOWN``,``GOOGLE_KEEP``,``AMAZON_CHIME``,``WORKDAY``,``FIFA``,``ROBLOX``,``WANGWANG``,``S7COMM_PLUS``,``DOH``,``AGORA_IO``,``MS_DFSR``,``WS_DISCOVERY``,``STUN``,``FOLDINGATHOME``,``GE_PROCIFY``,``MOXA_ASPP``,``APP_CH``,``GLASSDOOR``,``TINDER``,``BAIDU_TIEBA``,``MIMEDIA``,``FILESANYWHERE``,``HOUSEPARTY``,``GBRIDGE``,``HAMACHI``,``HEXATECH``,``HOTSPOT_SHIELD``,``MEGAPROXY``,``OPERA_VPN``,``SPOTFLUX``,``TUNNELBEAR``,``ZENMATE``, ``OPENGW``, ``VPNOVERDNS``, ``HOXX_VPN``, ``VPN1_COM``, ``SPRINGTECH_VPN``, ``BARRACUDA_VPN``, ``HIDEMAN_VPN``, ``WINDSCRIBE``, ``BROWSEC_VPN``, ``EPIC_BROWSER_VPN``, ``SKYVPN``, ``KPN_TUNNEL``, ``ERSPAN``,``EVASIVE_PROTOCOL``, ``DOTDASH``, ``ADOBE_DOCUMENT_CLOUD``, ``FLIPKART_BOOKS``
+
+- [PR #165](https://github.com/zscaler/terraform-provider-zia/pull/162) ``zia_url_filtering_rules`` Added new URL Categories
+
+## 2.3.3 (January, 1 2023)
+
+### Notes
+
+- Release date: **(January, 1 2023)**
+- Supported Terraform version: **v1.x**
 ## 2.3.2 (December, 30 2022)
 
 ### Notes

go.mod

@@ -6,7 +6,7 @@ require (
 	github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320
 	github.com/hashicorp/terraform-plugin-sdk v1.17.2
 	github.com/hashicorp/terraform-plugin-sdk/v2 v2.24.1
-	github.com/zscaler/zscaler-sdk-go v0.5.5
+	github.com/zscaler/zscaler-sdk-go v0.5.7
 )
 
 require (
@@ -23,7 +23,7 @@ require (
 	github.com/hashicorp/go-hclog v1.4.0 // indirect
 	github.com/hashicorp/go-multierror v1.1.1 // indirect
 	github.com/hashicorp/go-plugin v1.4.8 // indirect
-	github.com/hashicorp/go-retryablehttp v0.7.1 // indirect
+	github.com/hashicorp/go-retryablehttp v0.7.2 // indirect
 	github.com/hashicorp/go-uuid v1.0.3 // indirect
 	github.com/hashicorp/go-version v1.6.0 // indirect
 	github.com/hashicorp/hc-install v0.4.0 // indirect

go.sum

@@ -184,8 +184,8 @@ github.com/hashicorp/go-multierror v1.1.1/go.mod h1:iw975J/qwKPdAO1clOe2L8331t/9
 github.com/hashicorp/go-plugin v1.3.0/go.mod h1:F9eH4LrE/ZsRdbwhfjs9k9HoDUwAHnYtXdgmf1AVNs0=
 github.com/hashicorp/go-plugin v1.4.8 h1:CHGwpxYDOttQOY7HOWgETU9dyVjOXzniXDqJcYJE1zM=
 github.com/hashicorp/go-plugin v1.4.8/go.mod h1:viDMjcLJuDui6pXb8U4HVfb8AamCWhHGUjr2IrTF67s=
-github.com/hashicorp/go-retryablehttp v0.7.1 h1:sUiuQAnLlbvmExtFQs72iFW/HXeUn8Z1aJLQ4LJJbTQ=
-github.com/hashicorp/go-retryablehttp v0.7.1/go.mod h1:vAew36LZh98gCBJNLH42IQ1ER/9wtLZZ8meHqQvEYWY=
+github.com/hashicorp/go-retryablehttp v0.7.2 h1:AcYqCvkpalPnPF2pn0KamgwamS42TqUDDYFRKq/RAd0=
+github.com/hashicorp/go-retryablehttp v0.7.2/go.mod h1:Jy/gPYAdjqffZ/yFGCFV2doI5wjtH1ewM9u8iYVjtX8=
 github.com/hashicorp/go-safetemp v1.0.0/go.mod h1:oaerMy3BhqiTbVye6QuFhFtIceqFoDHxNAB65b+Rj1I=
 github.com/hashicorp/go-uuid v1.0.0/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro=
 github.com/hashicorp/go-uuid v1.0.1/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro=
@@ -358,8 +358,8 @@ github.com/zclconf/go-cty v1.12.1 h1:PcupnljUm9EIvbgSHQnHhUr3fO6oFmkOrvs2BAFNXXY
 github.com/zclconf/go-cty v1.12.1/go.mod h1:s9IfD1LK5ccNMSWCVFCE2rJfHiZgi7JijgeWIMfhLvA=
 github.com/zclconf/go-cty-debug v0.0.0-20191215020915-b22d67c1ba0b/go.mod h1:ZRKQfBXbGkpdV6QMzT3rU1kSTAnfu1dO8dPKjYprgj8=
 github.com/zclconf/go-cty-yaml v1.0.2/go.mod h1:IP3Ylp0wQpYm50IHK8OZWKMu6sPJIUgKa8XhiVHura0=
-github.com/zscaler/zscaler-sdk-go v0.5.5 h1:CZ4rEb1IrT7QRM2S7g9Nrtp9JxS8FOcN5ZgmxuGOqlk=
-github.com/zscaler/zscaler-sdk-go v0.5.5/go.mod h1:BvxM0j3xTM3Vb6FHUmuOKqRgNHv0EqGXfe99d1geUwc=
+github.com/zscaler/zscaler-sdk-go v0.5.7 h1:pofcewZTNMgCPnHtSxbKG5d23cRlo7pawnfIlNLvkBA=
+github.com/zscaler/zscaler-sdk-go v0.5.7/go.mod h1:ta9P9guhFY1ivEhesMUjdJ3+40AHsJOR4dEUDXLQ6z8=
 go.opencensus.io v0.21.0/go.mod h1:mSImk1erAIZhrmZN+AvHh14ztQfjbGwt4TtuofqLduU=
 go.opencensus.io v0.22.0/go.mod h1:+kGneAE2xo2IficOXnaByMWTGM9T73dGwxeWcUqIpI8=
 go.opencensus.io v0.22.2/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=

zia/resource_zia_url_filtering_rules.go

@@ -195,7 +195,7 @@ func resourceURLFilteringRules() *schema.Resource {
 			"users":               listIDsSchemaTypeCustom(4, "Name-ID pairs of users for which rule must be applied"),
 			"time_windows":        listIDsSchemaType("Name-ID pairs of time interval during which rule must be enforced."),
 			"override_users":      listIDsSchemaType("list of override users"),
-			"override_groups":     listIDsSchemaType("list of override groups"),
+			"override_groups":     listIDsSchemaTypeCustom(8, "Name-ID pairs of groups for which this rule can be overridden."),
 			"device_groups":       listIDsSchemaType("list of device groups"),
 			"devices":             listIDsSchemaType("list of devices"),
 			"location_groups":     listIDsSchemaTypeCustom(32, "list of locations groups"),