Skip to content

Commit

Permalink
* common.mk: Use $RUNRUBY for worker process.
Browse files Browse the repository at this point in the history
* lib/test/unit.rb: Fix bug.
* lib/test/unit.rb: @options[:ruby](@opts[:ruby]) is now Array.
* test/testunit/parallel.rb: Fix for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@30950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
  • Loading branch information
sorah committed Feb 24, 2011
1 parent cc61e92 commit 0695a5a
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 6 deletions.
7 changes: 7 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
Thu Feb 24 13:39:25 2011 Shota Fukumori (sora_h) <sorah@tubusu.net>

* common.mk: Use $RUNRUBY for worker process.
* lib/test/unit.rb: Fix bug.
* lib/test/unit.rb: @options[:ruby](@opts[:ruby]) is now Array.
* test/testunit/parallel.rb: Fix for above.

Thu Feb 24 10:05:55 2011 Shota Fukumori (sora_h) <sorah@tubusu.net>

* test/testunit/tests_for_parallel/misc.rb: Fix bug in r30947.
Expand Down
2 changes: 1 addition & 1 deletion common.mk
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ test: test-sample btest-ruby test-knownbug

test-all: $(TEST_RUNNABLE)-test-all
yes-test-all: PHONY
$(RUNRUBY) "$(srcdir)/test/runner.rb" $(TESTS)
$(RUNRUBY) "$(srcdir)/test/runner.rb" --ruby="$(RUNRUBY)" $(TESTS)
TESTS_BUILD = mkmf
no-test-all: PHONY
$(MINIRUBY) -I"$(srcdir)/lib" "$(srcdir)/test/runner.rb" $(TESTS_BUILD)
Expand Down
7 changes: 4 additions & 3 deletions lib/test/unit.rb
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def setup_options(opts, options)
end

opts.on '--ruby VAL', "Path to ruby; It'll have used at -j option" do |a|
options[:ruby] = a
options[:ruby] = a.split(/ /).reject(&:empty?)
end
end

Expand Down Expand Up @@ -364,8 +364,9 @@ def _run_suites suites, type
i,o = IO.pipe("ASCII-8BIT") # worker o>|i> master
j,k = IO.pipe("ASCII-8BIT") # worker <j|<k master
k.sync = true
pid = spawn(*@opts[:ruby].split(/ /),File.dirname(__FILE__) +
"/unit/parallel.rb", *@args, out: o, in: j)
pid = spawn(*@opts[:ruby],
"#{File.dirname(__FILE__)}/unit/parallel.rb",
*@args, out: o, in: j)
[o,j].each{|io| io.close }
{in: k, out: i, pid: pid, status: :waiting}
end
Expand Down
4 changes: 2 additions & 2 deletions test/testunit/test_parallel.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class TestParallelWorker < Test::Unit::TestCase
def setup
i, @worker_in = IO.pipe
@worker_out, o = IO.pipe
@worker_pid = spawn(*@options[:ruby].split(/ /), PARALLEL_RB,
@worker_pid = spawn(*@options[:ruby], PARALLEL_RB,
"-j", "t1", "-v", out: o, in: i)
[i,o].each(&:close)
end
Expand Down Expand Up @@ -124,7 +124,7 @@ def test_quit_in_test
class TestParallel < Test::Unit::TestCase
def spawn_runner(*opt_args)
@test_out, o = IO.pipe
@test_pid = spawn(*@options[:ruby].split(/ /), TESTS+"/runner.rb",
@test_pid = spawn(*@options[:ruby], TESTS+"/runner.rb",
"-j","t2","-x","sleeping",*opt_args, out: o)
o.close
end
Expand Down

0 comments on commit 0695a5a

Please sign in to comment.