Hotfix for Idle Wake issue #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdidron
approved these changes
Aug 18, 2020
yulei
reviewed
Aug 18, 2020
| @@ -232,7 +232,7 @@ int main(void) { | |||
| suspend_power_down(); // on AVR this deep sleeps for 15ms | |||
| /* Remote wakeup */ | |||
| if (suspend_wakeup_condition()) { | |||
| usbWakeupHost(&USB_DRIVER); | |||
There was a problem hiding this comment.
usbWakeupHost() must be used to send a resume signal to host (from J state to K state)
There was a problem hiding this comment.
A good question is, is this actually required, because, the lack of it doesn't seem to adversely affect the keyboard, nor it's ability to wake the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pulled from qmk#9962, as a hotfix to fix the issue where the board has issues waking up or initializing.
I'm not sure this is the best way to handle this, but ... we need something sooner rather than later.