Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate appfw plugins schema during component install #3866

Merged

Conversation

1000TurquoisePogs
Copy link
Member

Resolves #3863 by simply checking for appfwPlugin entries in a component manifest and then running a loop of getPluginDefinition() during the install extract step (called during both install and upgrade) but not caring about the output - it either passes or quits in error if schema is invalid.

I put this in a spot of the code where the component directory is still a temp dir - not yet resolved so that if a failure occurs then the folder can be removed.

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
…at exit can be handled after cleanup

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Copy link

github-actions bot commented Jun 14, 2024

build 5443 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9514900088

Copy link

github-actions bot commented Jun 14, 2024

Test workflow 4761 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3866/zowe-2.16.0-pr-3866-5443-20240614105731.pax
Running on machine: zzow06
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9514987918

@1000TurquoisePogs 1000TurquoisePogs changed the title Feature/v2/validate appfw during install Validate appfw plugins schema during component install Jun 14, 2024
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Copy link

github-actions bot commented Jun 24, 2024

build 5486 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9647111923

Copy link

github-actions bot commented Jun 24, 2024

Test workflow 4826 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3866/zowe-2.16.0-pr-3866-5486-20240624142926.pax
Running on machine: zzow06
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9647217396

Copy link

github-actions bot commented Jun 25, 2024

build 5490 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9662961092

Copy link

github-actions bot commented Jun 25, 2024

Test workflow 4832 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/2.16.0-PR-3866/zowe-2.16.0-pr-3866-5490-20240625130802.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/9663066600

@1000TurquoisePogs 1000TurquoisePogs merged commit 26107c9 into v2.x/staging Jun 25, 2024
11 checks passed
@1000TurquoisePogs 1000TurquoisePogs deleted the feature/v2/validate-appfw-during-install branch June 25, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate appFw pluginDefinition schema during zwe component install/upgrade
3 participants