Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surpress deprecated warnings for core components #1929

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

jackjia-ibm
Copy link
Member

@jackjia-ibm jackjia-ibm commented Jan 28, 2021

Signed-off-by: Jack (T.) Jia jack-tiefeng.jia@ibm.com

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Currently zowe runtime log will show deprecated messages like these:

  • unable to determine validate script from component zss manifest, fall back to default bin/validate.sh
  • unable to determine configure script from component zss manifest, fall back to default bin/configure.sh
  • unable to determine start script from component app-server manifest, fall back to default bin/start.sh

They are redundant since we know what we should do on core components.

Changes proposed in this PR

  • Remove those warnings for core components.

Does this PR introduce a breaking change?

  • Yes
  • No

Signed-off-by: Jack (T.) Jia <jack-tiefeng.jia@ibm.com>
@jackjia-ibm
Copy link
Member Author

All tests look ok except for the caching service failures we also see in staging branch.

Convenience build test: https://wash.zowe.org:8443/view/Zowe/job/zowe-install-test/view/change-requests/job/PR-1929/2
PTF test: https://wash.zowe.org:8443/view/Zowe/job/zowe-install-test/view/change-requests/job/PR-1929/3/
Docker test: https://wash.zowe.org:8443/view/Zowe/job/zowe-install-test/view/change-requests/job/PR-1929/4/

I also check the job log, all warnings are suppressed for core components and 2 new test cases work as expected.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. Thanks!

@stevenhorsman stevenhorsman merged commit cf88393 into staging Jan 29, 2021
@stevenhorsman stevenhorsman deleted the users/jack/hide-redundant-messages branch January 29, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants