Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external CA certs to env file, removed unused var #1742

Merged
merged 8 commits into from
Oct 22, 2020

Conversation

timgerstel
Copy link
Contributor

@timgerstel timgerstel commented Oct 15, 2020

Related to:
https://github.com/zowe/zlux-app-server/pull/138/files
zowe/zlux-server-framework#254

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Fixes #1736

Changes proposed in this PR

  • Export external certificate authorities to env file so that the app server may make use of this variable
  • Removed unused variable

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?


  • Affected function: certificate verification *

  • Description: Export EXTERNAL_CERTIFICATE_AUTHORITIES to zowe-certificates.env in keystore for use by app-server*

  • Part: name of customizable file involved *

multi-line description

Is there a related doc issue or Pull Request?

Doc issue/PR number:

Other information

…le so that app server may make use of it

Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>
Timothy Gerstel added 6 commits October 15, 2020 23:51
Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>
Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>
Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>
Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>
@timgerstel timgerstel changed the title [WIP] Add external CA certs to env file Add external CA certs to env file, removed unused var Oct 21, 2020
@timgerstel timgerstel marked this pull request as ready for review October 21, 2020 21:21
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was curious why this information wasn't previously recorded and thought it might be needed at some point, so this makes sense to me.

Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>
@1000TurquoisePogs 1000TurquoisePogs merged commit ac89e36 into zowe:staging Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants