Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error correlator and troubleshoot webview #3243

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

traeok
Copy link
Member

@traeok traeok commented Oct 15, 2024

Proposed changes

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
traeok and others added 3 commits October 16, 2024 14:02
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
…3248)

* fix(api): Fix profile references being lost when cache is refreshed

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

* fix: Pass profile instead of profile name for updating creds

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

---------

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>
This reverts commit 53e9518.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 92.64305% with 27 lines in your changes missing coverage. Please review.

Project coverage is 92.95%. Comparing base (e4a190e) to head (d9e022a).

Files with missing lines Patch % Lines
...ges/zowe-explorer-api/src/utils/ErrorCorrelator.ts 90.41% 7 Missing ⚠️
...kages/zowe-explorer/src/trees/uss/UssFSProvider.ts 92.45% 4 Missing ⚠️
packages/zowe-explorer-api/src/fs/BaseProvider.ts 76.92% 3 Missing ⚠️
...kages/zowe-explorer/src/trees/shared/SharedInit.ts 50.00% 3 Missing ⚠️
packages/zowe-explorer/src/utils/AuthUtils.ts 92.85% 3 Missing ⚠️
...kages/zowe-explorer/src/utils/TroubleshootError.ts 92.00% 2 Missing ⚠️
...s/zowe-explorer/src/commands/UnixCommandHandler.ts 66.66% 1 Missing ⚠️
...ges/zowe-explorer/src/trees/dataset/DatasetTree.ts 50.00% 1 Missing ⚠️
packages/zowe-explorer/src/trees/job/JobActions.ts 90.00% 1 Missing ⚠️
...kages/zowe-explorer/src/trees/job/JobFSProvider.ts 96.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3243      +/-   ##
==========================================
- Coverage   93.05%   92.95%   -0.10%     
==========================================
  Files         113      115       +2     
  Lines       11728    11885     +157     
  Branches     2530     2578      +48     
==========================================
+ Hits        10913    11048     +135     
- Misses        813      835      +22     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok marked this pull request as ready for review October 21, 2024 20:24
Copy link

github-actions bot commented Oct 21, 2024

📅 Suggested merge-by date: 11/5/2024

@traeok
Copy link
Member Author

traeok commented Oct 21, 2024

Sorry for the early request to review - need to account for a couple more things before its ready should be good to go now 😋

  • Allow extenders to contribute to the correlator
  • Allow extenders to add custom resources to the correlator to display during Troubleshooting (stretch)

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions for the changelogs.

packages/zowe-explorer-api/CHANGELOG.md Outdated Show resolved Hide resolved
packages/zowe-explorer/CHANGELOG.md Outdated Show resolved Hide resolved
packages/zowe-explorer/CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok requested a review from anaxceron October 22, 2024 19:33
anaxceron
anaxceron previously approved these changes Oct 22, 2024
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changelogs, thanks @traeok!

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@traeok traeok marked this pull request as ready for review October 22, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

3 participants