Removing icon names from translated strings

[phaumer]

Proposed changes

Several strings had icon names, e.g. menu items that show an icon on the left, embedded into the localized portion of the string. These references to the icon names then got translated by the machine translation, which broke the menu items.

Release Notes

Milestone:

Changelog:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds or improves functionality)
• Breaking change (a change that would cause existing functionality to not work as expected)
• Documentation (Markdown, README updates)
• Other (please specify above in "Proposed changes" section)

Checklist

General

• I have read the CONTRIBUTOR GUIDANCE wiki
• All PR dependencies have been merged and published (if applicable)
• A GIF or screenshot is included in the PR for visual changes
• The pre-publish command has been executed:
  • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
  • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

• There is coverage for the code that I have added
• I have added new test cases and they are passing
• I have manually tested the changes

Deployment

• I have added developer documentation (if applicable)
• Documentation should be added to Zowe Docs
  • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
  • Otherwise, please check with the rest of the squad about any needed documentation before merging.
• These changes may need ported to the appropriate branches (list here):

Further comments

[codecov]

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.97%. Comparing base (525d29d) to head (4270607).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/zowe-explorer/src/trees/job/JobInit.ts	0.00%	1 Missing ⚠️
packages/zowe-explorer/src/trees/uss/USSInit.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #3239    +/-   ##
========================================
  Coverage   92.97%   92.97%            
========================================
  Files         113      113            
  Lines       11661    11663     +2     
  Branches     2604     2467   -137     
========================================
+ Hits        10842    10844     +2     
  Misses        817      817            
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📅 Suggested merge-by date: 10/28/2024

[phaumer]

Here are the updated translations for this PR: https://zowe.jfrog.io/artifactory/libs-snapshot-local/org/zowe/vscode/zowe-explorer-g11n/zowe-explorer-g11n-20241014-181610.zip

[t1m0thyj]

LGTM, thanks @phaumer for updating these strings and fixing some typos too!

[zFernand0]

LGTM! 😋
I hope it wasn't too tedious to move the icons into the code 😋

[t1m0thyj]

Here are the updated translations for this PR: https://zowe.jfrog.io/artifactory/libs-snapshot-local/org/zowe/vscode/zowe-explorer-g11n/zowe-explorer-g11n-20241014-181610.zip

Merging, updated translations have been uploaded to POEditor so the next ZE release will include them 🙂