Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zFTP: Spool files are not listed properly for active jobs #2832

Closed
traeok opened this issue Apr 10, 2024 · 3 comments · Fixed by #2869
Closed

zFTP: Spool files are not listed properly for active jobs #2832

traeok opened this issue Apr 10, 2024 · 3 comments · Fixed by #2869
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. zFTP
Milestone

Comments

@traeok
Copy link
Member

traeok commented Apr 10, 2024

Describe the bug

Related: zowe/zowe-cli-ftp-plugin#156

Spool files are not listed properly for active jobs using a zFTP profile. This applies to both v2 and v3.
This is a limitation in zos-node-accessor: https://github.com/IBM/zos-node-accessor/blob/60cdfd26eea001686d50a92128f12a6fff0f91ca/lib/zosAccessor.js#L867-L868

To Reproduce

  • Try to expand a job that's active under a zFTP profile
  • Notice that there is only one spool file listed, named [(0)], and it has no information
  • Opening said file results in an editor tab named 0 to appear with no contents

Expected behavior

We should either:

  • show a placeholder node to say that FTP profiles do not support listing spool files for active jobs
  • not show any spool files

I prefer the first option because it provides context for the failure when listing spool files.

Screenshots

image

Desktop (please complete the following information):

  • OS: Windows 10
  • Zowe Explorer Version: v2.15.2
@traeok traeok added the bug Something isn't working label Apr 10, 2024
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@traeok traeok changed the title zFTP: Spool files are not handled properly for active jobs zFTP: Spool files are not listed properly for active jobs Apr 10, 2024
@traeok traeok added the zFTP label Apr 10, 2024
@JTonda JTonda added severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. priority-medium Not functioning - next quarter if capacity permits labels Apr 16, 2024
@traeok
Copy link
Member Author

traeok commented Apr 16, 2024

@JillieBeanSim suggested that we should catch any errors from the extender and then handle those errors accordingly in Zowe Explorer. In hindsight, I prefer this option over the above solutions mentioned, because it is consistent with our expectations for extenders to handle errors where applicable.

@t1m0thyj t1m0thyj linked a pull request May 2, 2024 that will close this issue
16 tasks
@JillieBeanSim JillieBeanSim added this to the v2.16.0 milestone May 8, 2024
@JillieBeanSim
Copy link
Contributor

closing with merge of linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. zFTP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants