Skip to content

Conversation

@t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jun 20, 2025

What It Does

Fixes failing audit workflow. This is a major version bump for urllib3, but it should be ok - it's used in conjunction with requests, which is compatible with both 1.x and 2.x (urllib3<3,>=1.21.1).

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.05%. Comparing base (8ee471c) to head (fd16498).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files          65       65           
  Lines        3340     3340           
=======================================
  Hits         2941     2941           
  Misses        399      399           
Flag Coverage Δ
unittests 88.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@pem70 pem70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t1m0thyj t1m0thyj merged commit d5299bc into main Jun 21, 2025
22 checks passed
@t1m0thyj t1m0thyj deleted the t1m0thyj-patch-1 branch June 21, 2025 15:08
@github-project-automation github-project-automation bot moved this from Review/QA to Closed in Zowe CLI Squad Jun 21, 2025
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

Release succeeded for the main branch. 🎉

The following packages have been published:

  • pypi: zowe-python-sdk-bundle-1.0.0.dev23
  • pypi: zowe_core_for_zowe_sdk-1.0.0.dev23
  • pypi: zowe_zos_console_for_zowe_sdk-1.0.0.dev23
  • pypi: zowe_zos_files_for_zowe_sdk-1.0.0.dev23
  • pypi: zowe_zos_jobs_for_zowe_sdk-1.0.0.dev23
  • pypi: zowe_zos_tso_for_zowe_sdk-1.0.0.dev23
  • pypi: zowe_zosmf_for_zowe_sdk-1.0.0.dev23

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants