Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exec-data option in zowe jobs list jobs command #1354

Merged
merged 19 commits into from
Apr 11, 2022

Conversation

namanpatel1112
Copy link
Contributor

Resolves #1158

Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1354 (00ff76b) into master (c5a67fe) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
- Coverage   90.94%   90.94%   -0.01%     
==========================================
  Files         358      358              
  Lines        5268     5276       +8     
  Branches      730      733       +3     
==========================================
+ Hits         4791     4798       +7     
- Misses        472      473       +1     
  Partials        5        5              
Impacted Files Coverage Δ
...kages/cli/src/zosjobs/list/jobs/Jobs.definition.ts 100.00% <ø> (ø)
packages/cli/src/zosjobs/list/jobs/Jobs.handler.ts 92.30% <80.00%> (-7.70%) ⬇️
packages/zosjobs/src/GetJobs.ts 97.34% <100.00%> (+0.09%) ⬆️
packages/zosjobs/src/JobsConstants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ffdaf...00ff76b. Read the comment docs.

Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
@namanpatel1112 namanpatel1112 marked this pull request as ready for review March 28, 2022 14:24
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
@namanpatel1112 namanpatel1112 changed the title add data-exec option in zowe jobs list jobs command add exec-data option in zowe jobs list jobs command Mar 30, 2022
packages/cli/src/zosjobs/list/jobs/Jobs.definition.ts Outdated Show resolved Hide resolved
packages/cli/CHANGELOG.md Outdated Show resolved Hide resolved
packages/cli/src/zosjobs/list/jobs/Jobs.definition.ts Outdated Show resolved Hide resolved
packages/cli/src/zosjobs/list/jobs/Jobs.definition.ts Outdated Show resolved Hide resolved
packages/cli/src/zosjobs/list/jobs/Jobs.definition.ts Outdated Show resolved Hide resolved
packages/cli/src/zosjobs/list/jobs/Jobs.definition.ts Outdated Show resolved Hide resolved
packages/cli/CHANGELOG.md Outdated Show resolved Hide resolved
packages/zosjobs/CHANGELOG.md Outdated Show resolved Hide resolved
packages/zosjobs/CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for renaming the CLI option 🙂 Left a few more comments about making the API property name consistent with the CLI option name.

packages/zosjobs/src/doc/input/IGetJobsParms.ts Outdated Show resolved Hide resolved
packages/zosjobs/src/GetJobs.ts Outdated Show resolved Hide resolved
packages/cli/src/zosjobs/list/jobs/Jobs.handler.ts Outdated Show resolved Hide resolved
packages/cli/src/zosjobs/list/jobs/Jobs.handler.ts Outdated Show resolved Hide resolved
Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
@namanpatel1112
Copy link
Contributor Author

Thanks for renaming the CLI option 🙂 Left a few more comments about making the API property name consistent with the CLI option name.

Thanks, I just updated the PR with the changes.

Signed-off-by: namanpatel1112 <namanpatel1112@gmail.com>
@namanpatel1112 namanpatel1112 requested review from zFernand0 and removed request for zFernand0 April 11, 2022 12:39
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.7% 86.7% Coverage
0.0% 0.0% Duplication

@t1m0thyj t1m0thyj merged commit 7e35457 into master Apr 11, 2022
@t1m0thyj t1m0thyj deleted the 1158-JobsList-ExecData-Enhancement branch April 11, 2022 19:36
@zFernand0 zFernand0 removed their request for review January 19, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zowe jobs list jobs option to return execution data about each job
4 participants