Complete Refactor of Sample React App Using Latest Best Practices and Syntax (create-react-app compatibility) #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project was created using create-react-app and allows developers to use the latest react practices rather than the previous boilerplate which was a complete hack of an implementation for the React framework. This PR updates the webpack config to be completely compatible.
CSS works completely. Plugin inject resources (metadata, component logger) work completely.
This PR will open Zowe development to an even wider range of programmers by enabling the use of conventional React practices. For example, the current sample-react-app loads CSS styles from a JS file, THEN applying them programmatically using the style tag: https://github.com/zowe/sample-react-app/blob/v3.x/staging/webClient/src/SamplePage.tsx#L33
And then the amount of props passed to this one sample page component????!?!?!? https://github.com/zowe/sample-react-app/blob/v3.x/staging/webClient/src/App.tsx#L314
I do not believe React was ever intended to be used in the manner of the example above.
This PR depends on:
zowe/zlux-app-manager#667
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments