[Backport] Fix code smells

[awharn]

Backport the code smell fixes to V1 LTS

[codecov]

Codecov Report

Base: 82.70% // Head: 82.70% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (7eff9cd) compared to base (2d15654).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@               Coverage Diff               @@
##           zowe-v1-lts     zowe/imperative#879      +/-   ##
===============================================
- Coverage        82.70%   82.70%   -0.01%     
===============================================
  Files              163      163              
  Lines             7949     7948       -1     
  Branches          1455     1454       -1     
===============================================
- Hits              6574     6573       -1     
  Misses            1371     1371              
  Partials             4        4              

Impacted Files	Coverage Δ
packages/cmd/src/profiles/CliProfileManager.ts	96.42% <100.00%> (-0.02%)	⬇️
packages/cmd/src/response/CommandResponse.ts	97.04% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[t1m0thyj]

The "code smells" are just because of isNullOrUndefined statements which were there before, so nothing new. LGTM 👍

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells

100.0% Coverage
0.0% Duplication

[zFernand0]

to make sonarcloud happy again, should we replace the isNullOrUndefined in this file:

• packages/cmd/src/profiles/CliProfileManager.ts

I'm happy to merge as-is since the changes LGTM though 😋

[zFernand0]

merging as-is since we already have this issue:

• Remove deprecated/unstable Utils functions zowe-cli#1947

[github-actions]

Release succeeded for the zowe-v1-lts branch. 🎉

The following packages have been published:

• npm: @zowe/imperative@4.18.9

_{Powered by Octorelease 🚀}