Tokens #399

gejohnston · 2020-05-12T18:40:37Z

Implemented the infrastructure to enable CLI commands to process tokens.

Modified AbstractSession.buildSession() to use a token for authentication if a token is present in the underlying REST session configuration object.
Added a new CredsForSessCfg.addCredsOrPrompt function that places credentials (including a possible token) into a session configuration object.
- Credentials are obtained from the command line, environment variables, or a profile.
- If no credentials are available, it will prompt for a user name and password.
- Any prompt will timeout after 30 seconds so that it will not hang an automated script.
All commands will automatically benefit from token handling.
Only commands that convert to CredsForSessCfg.addCredsOrPrompt() will benefit from prompting for user name and password.

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

Signed-off-by: Jack (T.) Jia <jack-tiefeng.jia@ibm.com>

Switch to SonarCloud

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

[next] Use new Zowe artifactory and fix yargs vulnerability

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

* adding generic GET and PUT methods returning full response - response can be tailored - created needed interfaces Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * - `extractExpectedData` now returns full `client` object as default - `getFull` and `putFull` now returns only one type, i.e. `IRestClientResponse` Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * adding methods for post and delete Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * - remove unneeded comments - refactor according to new naming - changed `performRest` into a wrapper for `performRestCall` - marked `performRest` as deprecated Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * Get build to pass with latest yargs Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Get help and version commands to work with new yargs Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Fix undefined value error in plugin (un)install handlers Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Fix undefined error that was missed in plugin install handler Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Update Yargs on the other package.json files Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com> * Hopefully fix cmd cli integration tests Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Make linter happy and update Keytar in test CLIs Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Simplify code to obtain command line text Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Fix missing keytar dep in imperative-test-cli Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Updating dependencies [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Bump version to 4.4.5 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Fix unit tests for Node 12 Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Fix integration tests for Node 12 Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Update yargs to 15.1.0 Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * adding few unit tests Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * add specific version regarding depreciation of AbstractRestClient method Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * fix lint issue regarding shadowed variable Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * update unit test switch from snapshot verification to checking if values are defined or not Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * linting again :P Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * Fix several formatting issues in web help HTML Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Fix script errors in Edge and print button alignment Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Remove unnecessary snapshots from tests Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Fix line breaks getting lost during Markdown to HTML conversion Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Bump version to 4.4.6 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Updating dependencies [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Bump version to 4.4.7 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * addressing comments on PR #348 - change name from `performRestCall` to `request` - remove useless interface `IFullResponseOptions` - rename interface from `IOptionsFullRequest` to `IOptionsFullResponse` since it defines input options related to fullResponse expects - added missing tydoc information - Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * fix linting Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * update unit test following Interface name change Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * - added more unit tests - moved deprecation message to the top - updated all restClient methods to call .request() instead of .performRest() Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * remove unnecessary comments Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * skipped a few comments :( hopefully this time all are gone Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> * Update Jenkinsfile Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com> * Updating dependencies [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Add missing colon. Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com> * Bump version to 4.5.0 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Mirror master branch to zowe-v1-lts Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Exported IRestOptions in packages/rest/index.ts Signed-off-by: Megha Kumari <meghajais.mj@hotmail.com> * Made the new changes Signed-off-by: Megha Kumari <meghajais.mj@hotmail.com> * Changed the type of symlink from dir to junction Signed-off-by: Megha Kumari <meghajais.mj@hotmail.com> * Resolved the error Signed-off-by: Megha Kumari <meghajais.mj@hotmail.com> * Revert "Resolved the error" This reverts commit ae326ef. Signed-off-by: Megha Kumari <meghajais.mj@hotmail.com> * Resolved the type of symlink Signed-off-by: Megha Kumari <meghajais.mj@hotmail.com> * Don't load secure profile fields when deleting profile Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Allow specifying secure values as optional to ignore when they are missing Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Add unit tests around loading optional secure fields Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Updating dependencies [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Bump version to 4.5.1 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Updating dependencies [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Bump version to 4.5.2 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Update changelog for zowe-v1-lts Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Update contribution guidelines Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Fix breaking change listed in changelog for v4 Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * fixed alignment Signed-off-by: mheuzey <michael.heuzey@gmail.com> * Add changelog automation Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com> * Updating dependencies [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Bump version to 4.5.3 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Fix vulnerabilities and remove unnecessary mkdirp dependency Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Update package-lock and remove for test CLIs Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Update changelog Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Remove lines parameter for changelog stages in pipeline Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Remove lines parameter for changelog stages in pipeline Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com> * Bump version to 4.5.4 [ci skip] Signed-off-by: zowe-robot <zowe.robot@gmail.com> * Update Changelog [ci skip] Co-authored-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com> Co-authored-by: Andrew W. Harn <andrew.harn@broadcom.com> Co-authored-by: zowe-robot <zowe.robot@gmail.com> Co-authored-by: Fernando Rijo Cedeno <fernando.rijocedeno@broadcom.com> Co-authored-by: Megha Kumari <meghajais.mj@hotmail.com> Co-authored-by: mheuzey <michael.heuzey@gmail.com> Signed-off-by: zFernand0 <fernando.rijocedeno@broadcom.com>

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

dkelosky · 2020-05-18T15:57:43Z

__tests__/config/unit/jest.config.json

@@ -10,6 +10,7 @@
    "coverageReporters": [
        "json",
        "lcov",
+        "html",


@zFernand0

This proposed change gives this on npm run test:unit --coverage:

ok im crazy - ill revert this

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

sonarcloud · 2020-05-18T17:13:28Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 2 Security Hotspots to review)
0 Code Smells

84.5% Coverage
0.0% Duplication

Signed-off-by: Gene Johnston <eugene.johnston@broadcom.com>

It impacts tests. Signed-off-by: Gene Johnston <eugene.johnston@broadcom.com>

Signed-off-by: Gene Johnston <eugene.johnston@broadcom.com>

Signed-off-by: <>

Signed-off-by: Gene Johnston <eugene.johnston@broadcom.com>

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

dkelosky and others added 30 commits October 29, 2019 21:39

parse token and add type to cookier

bf18ff1

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

Fix #37

fb7941b

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

remove token from basic auth check

e504317

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

pass IProfileLoaded to commands

a138f5e

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

get base64 credentials

2c0e7ae

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

fix #316

f8e0292

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

typo

d25531e

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

correctly obtain token value

694882c

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

use new typings

2fd92c7

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

pipeline updates for branch

f69f024

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

update api method name

63a3dc4

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

node 12 typings

a3829ff

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

revert loader change

577bf5e

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

add a note for CLI users

652682f

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

stage in next branch

4aafa31

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

eliminate unused function

3d47c18

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

lint fix

f7e43b3

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

here i go again

b581ab4

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

Updating dependencies [ci skip]

7e793b9

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

Bump version to 5.0.0-next.201911011856 [ci skip]

76cd7db

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

Switch to SonarCloud

51f77ac

Signed-off-by: Jack (T.) Jia <jack-tiefeng.jia@ibm.com>

rename stage

37b9417

Signed-off-by: Jack (T.) Jia <jack-tiefeng.jia@ibm.com>

Merge pull request #331 from zowe/users/jack/sonarcloud-next

a54eee8

Switch to SonarCloud

Update to Zowe artifactory and get building with Node 12

fe6bd53

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Merge branch 'master' into fix-next

5e335d4

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Merge pull request #351 from zowe/fix-next

65788e7

[next] Use new Zowe artifactory and fix yargs vulnerability

Updating dependencies [ci skip]

83091d8

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

Bump version to 5.0.0-next.202001151750 [ci skip]

4762405

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

Bump version to 5.0.0-next.202003262002 [ci skip]

fb579b9

Signed-off-by: zowe-robot <zowe.robot@gmail.com>

test getMeta without name

7ba80e2

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

dkelosky reviewed May 18, 2020

View reviewed changes

extra getMeta test cases

623599e

Signed-off-by: Dan Kelosky <dkelosky@gmail.com>

gejohnston and others added 25 commits May 18, 2020 19:19

Add tests for sleep and promptWithTimeout.

310d366

Signed-off-by: Gene Johnston <eugene.johnston@broadcom.com>

Ensure writeToOutputOrig is defined before using it.

dfb09cb

It impacts tests. Signed-off-by: Gene Johnston <eugene.johnston@broadcom.com>

Add mock-stdin.

fad322c

Signed-off-by: Gene Johnston <eugene.johnston@broadcom.com>

Merge branch 'tokens' of https://github.com/zowe/imperative into tokens

9c3b4f5

Signed-off-by: <>

Only move assignment of writeToOutputOrig early.

9e7fe36

Signed-off-by: Gene Johnston <eugene.johnston@broadcom.com>

Add base profile to command definitions containing other profile types

6f25746

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Fix profile fields set to null when they should be undefined

4212b90

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Add base profile to command definitions containing other profile types

72d6e95

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Don't add base profile if none is defined in Imperative config

4728348

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Add integration test for fields defined in base profile

c0214f0

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Add unit test for base profiles in getProfileGroup

50269fa

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Add unit test and fix snapshots

06144cc

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Update changelog

bd2f866

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>

Add initial implementation.

37c4d6e

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Make specific to create profile command

2319aca

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Add initial implementation.

9818069

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Make specific to create profile command

f03cd00

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Rebase off of add-base-profile

4da62d7

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Update unit test snapshots

eb1257a

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Add initial implementation.

7b68ffb

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Make specific to create profile command

bc7119a

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Add initial implementation.

9d6e4f6

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Make specific to create profile command

3a4de10

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Update test snapshots

48af221

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

Update Changelog

ac006ac

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

gejohnston closed this May 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tokens #399

Tokens #399

gejohnston commented May 12, 2020

dkelosky May 18, 2020

dkelosky May 18, 2020

sonarcloud bot commented May 18, 2020

Tokens #399

Tokens #399

Conversation

gejohnston commented May 12, 2020

dkelosky May 18, 2020

Choose a reason for hiding this comment

dkelosky May 18, 2020

Choose a reason for hiding this comment

sonarcloud bot commented May 18, 2020