Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keyring setup doc #1421

Merged
merged 13 commits into from
Sep 30, 2020
Merged

Update keyring setup doc #1421

merged 13 commits into from
Sep 30, 2020

Conversation

stevenhorsman
Copy link
Member

Signed-off-by: stevenhorsman steven@uk.ibm.com

Description

Resolves: #1413

  • Update the keyring certificate configuration doc to reference the new keyring.env file
  • Add some clarity about how to run zowe-setup-certificates.sh

@stevenhorsman
Fix some confusion and add new file refs
57ddee6 
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman mentioned this pull request Sep 16, 2020
Merged
nannanli
nannanli approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@nannanli nannanli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenhorsman Hi Steve, this PR looks good. Thanks for the updates! Can this PR be merged now? Do we need review from anyone?

@stevenhorsman
Copy link
Member Author

I'd like a review from @Joe-Winchester - which should come with the dev PR review

@nannanli nannanli added area: zos-install-upgrade Issues related to Zowe z/OS components installation, mostly using convenience build. type: enhancement New feature or request labels Sep 23, 2020
@Joe-Winchester
Copy link
Member

@nannanli - as part of my review I sort of took over this branch (after chatting to Steve) and it now contains 16 changes file.

  • keystore and keyring docs following customer feedback where there was confusion
  • consolidate all chapters to get consistency for use of RUNTIME_DIR
  • Added a Zowe topology diagram to explain the directories for RUNTIME_DIR, INSTANCE_DIR, KEYSTORE_DIR and their relationships
    Could you please do a review as I'm sure I've made a number of mistakes and omissions and it'd be great to get your feedback.

@nannanli
Edits
d11ff0c 
Signed-off-by: nannanli <nannanli@cn.ibm.com>
- Fixed typos, a link
- Edited wording
@nannanli
Copy link
Member

@Joe-Winchester Hi Joe, I've edited the topics to fix some small issues. See my changes here. Thanks for creating the diagrams which makes it much easier to understand the topology!

@nannanli nannanli merged commit 98eea9d into docs-staging Sep 30, 2020
@nannanli nannanli deleted the users/stevenh/ds-1413 branch September 30, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nannanli nannanli nannanli approved these changes

@Joe-Winchester Joe-Winchester Joe-Winchester approved these changes

Assignees
No one assigned
Labels
area: zos-install-upgrade Issues related to Zowe z/OS components installation, mostly using convenience build. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenhorsman @Joe-Winchester @nannanli