Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resource trees to common TreeItem #214

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

AndrewTwydell
Copy link
Contributor

What It Does

Requires PR #213

Most code for each resource tree was repeated. This uses a common tree and arguments to create the trees.

It also removes the top level Web folder as this was fed back as unecessary.

This will allow us to create a panel for users to select which resources they'd like trees for to unclutter the treeview.

Review Checklist
I certify that I have:

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 55.20170% with 211 lines in your changes missing coverage. Please review.

Project coverage is 36.06%. Comparing base (b51d5c2) to head (7ed04ed).

Files with missing lines Patch % Lines
...rees/CICSCombinedTrees/CICSCombinedResourceTree.ts 19.44% 29 Missing ⚠️
...ckages/vsce/src/commands/clearPlexFilterCommand.ts 12.90% 27 Missing ⚠️
...ackages/vsce/src/commands/showAttributesCommand.ts 0.00% 25 Missing ⚠️
...ckages/vsce/src/commands/getFilterPlexResources.ts 4.34% 22 Missing ⚠️
packages/vsce/src/trees/CICSPlexTree.ts 0.00% 14 Missing ⚠️
packages/vsce/src/trees/CICSTree.ts 0.00% 9 Missing ⚠️
packages/vsce/src/commands/inquireProgram.ts 25.00% 6 Missing ⚠️
packages/vsce/src/commands/inquireTransaction.ts 33.33% 6 Missing ⚠️
...ommands/disableCommands/disableLocalFileCommand.ts 0.00% 5 Missing ⚠️
.../commands/disableCommands/disableProgramCommand.ts 0.00% 5 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   28.56%   36.06%   +7.50%     
==========================================
  Files         147      134      -13     
  Lines        5031     3943    -1088     
  Branches      882      618     -264     
==========================================
- Hits         1437     1422      -15     
+ Misses       3594     2521    -1073     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndrewTwydell AndrewTwydell force-pushed the resource-tree-refactor branch from e88ece5 to bed32ab Compare January 28, 2025 12:24
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
@AndrewTwydell AndrewTwydell force-pushed the resource-tree-refactor branch from 852e2c5 to 4696f7a Compare January 28, 2025 17:57
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Signed-off-by: Andrew Twydell <andrew.twydell@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants