Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCE: Renamed to IBM CICS for Zowe Explorer #135

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

zFernand0
Copy link
Member

What It Does

Renames the extension to IBM CICS for Zowe Explorer

Review Checklist
I certify that I have:

fix #129

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (dcee3e5) to head (df66423).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   93.28%   93.28%           
=======================================
  Files          74       74           
  Lines         760      760           
  Branches       94       93    -1     
=======================================
  Hits          709      709           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the name here too? We may be able to make it dynamic with context.extension.name or something similar rather than being hardcoded.

logger.error("Zowe Explorer for IBM CICS was not initiliaized correctly");

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 requested a review from t1m0thyj August 1, 2024 12:27
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks @zFernand0 for the renaming!

packages/vsce/.gitignore Outdated Show resolved Hide resolved
Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 requested a review from traeok August 1, 2024 13:17
@zFernand0 zFernand0 merged commit 5365e01 into main Aug 1, 2024
19 checks passed
@zFernand0 zFernand0 deleted the zfernand0/fix-129 branch August 1, 2024 18:14
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Rename the Zowe CICS VS Code extension per Linux Foundation trademark guidelines
5 participants