Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background downloads #832

Merged
merged 19 commits into from
Feb 29, 2024
Merged

Background downloads #832

merged 19 commits into from
Feb 29, 2024

Conversation

michalrentka
Copy link
Contributor

No description provided.

@michalrentka michalrentka requested a review from mvasilak January 16, 2024 11:10
@michalrentka michalrentka force-pushed the autodownload branch 2 times, most recently from 1bb9e2f to c305a84 Compare January 26, 2024 10:31
@michalrentka michalrentka marked this pull request as ready for review January 26, 2024 10:35
@michalrentka michalrentka force-pushed the autodownload branch 2 times, most recently from 549e395 to 0b9c1de Compare February 20, 2024 10:20
mvasilak
mvasilak approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mvasilak mvasilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AttachmentDownloadOperation is not used anymore, we can delete it or at least remove it from targets.

Plus some other minor code improvements.

Zotero/Controllers/Attachment Downloader/AttachmentDownloader.swift Outdated Show resolved Hide resolved
Zotero/Controllers/Attachment Downloader/AttachmentDownloader.swift Outdated Show resolved Hide resolved
Zotero/Controllers/Attachment Downloader/AttachmentDownloader.swift Outdated Show resolved Hide resolved
Zotero/Controllers/Attachment Downloader/AttachmentDownloader.swift Outdated Show resolved Hide resolved
Zotero/Controllers/Attachment Downloader/AttachmentDownloader.swift Outdated Show resolved Hide resolved
Zotero/Controllers/Attachment Downloader/AttachmentDownloader.swift Outdated Show resolved Hide resolved
Zotero/Controllers/Attachment Downloader/AttachmentDownloader.swift Outdated Show resolved Hide resolved
@michalrentka michalrentka force-pushed the autodownload branch 2 times, most recently from 5aff49b to fd4cca1 Compare February 22, 2024 12:05
@michalrentka
Copy link
Contributor Author

Got it, resolved in fd4cca1

@michalrentka michalrentka force-pushed the autodownload branch 2 times, most recently from 7cd3c38 to 720611f Compare February 28, 2024 10:51
@michalrentka michalrentka merged commit ec7dbc1 into zotero:master Feb 29, 2024
1 check passed
@michalrentka michalrentka deleted the autodownload branch February 29, 2024 14:34
mvasilak added a commit to mvasilak/zotero-ios that referenced this pull request Mar 19, 2024
@mvasilak
Revert "Background downloads (zotero#832)"
5958204 
ec7dbc1
mvasilak added a commit to mvasilak/zotero-ios that referenced this pull request Mar 19, 2024
@mvasilak
Apply partially "Background downloads (zotero#832)"
0cc6016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvasilak mvasilak mvasilak approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalrentka @mvasilak