Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transformed annotation user #1045

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

mvasilak
Copy link
Contributor

@mvasilak mvasilak commented Dec 13, 2024

Fixes issue reported in forum post

When an annotation is transformed, e.g. due to overlapping rects or rects that need to be split, the new annotations are added using document.add. If these annotations have an empty string for the user field, the field is converted to nil. This will cause the PSPDFKIT annotation to be added in the database with createdBy = nil, until the next sync happens, that will assign the proper user.

Guarantying a non-empty user field, alleviates the issue. Alternatively, we can consider adding the username, or even better the userId, in the annotation customData, and not rely at all on user.

@mvasilak mvasilak merged commit fa9a16c into zotero:master Dec 14, 2024
1 check passed
@mvasilak mvasilak deleted the fix-transformed-annotation-user branch December 14, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants