Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported in forum post
When an annotation is transformed, e.g. due to overlapping rects or rects that need to be split, the new annotations are added using
document.add
. If these annotations have an empty string for theuser
field, the field is converted tonil
. This will cause the PSPDFKIT annotation to be added in the database withcreatedBy = nil
, until the next sync happens, that will assign the proper user.Guarantying a non-empty
user
field, alleviates the issue. Alternatively, we can consider adding theusername
, or even better theuserId
, in the annotationcustomData
, and not rely at all onuser
.