Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUB/Snapshot: Keyboard accessibility improvements for annotations #150

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
a7a1f05
EPUB/Snapshot: Keyboard accessibility improvements for annotations
AbeJellinek Nov 12, 2024
1b6e437
Fix EPUB find annotation shortcuts
AbeJellinek Nov 13, 2024
27dfbbf
EPUB/Snapshot: Enable annotation focus keyboard navigation
AbeJellinek Nov 14, 2024
98a0867
EPUB/Snapshot: Allow moving note annotations with keyboard
AbeJellinek Nov 14, 2024
9b89847
Only focus elements that are already in view
AbeJellinek Nov 14, 2024
b8d3c77
Calculate focus state lazily
AbeJellinek Nov 14, 2024
74074fd
Fix dummy selection remaining in some cases
AbeJellinek Nov 15, 2024
635dd9e
Prevent scroll on Escape
AbeJellinek Nov 15, 2024
592b03c
Create note in center of screen by default
AbeJellinek Nov 15, 2024
abf7202
Update annotation text when moved/resized via keyboard
AbeJellinek Nov 15, 2024
b8f1c38
Disable annotation creation shortcuts when annotation is selected
AbeJellinek Nov 15, 2024
28fcb83
Fix another case where selection could remain after resize
AbeJellinek Nov 15, 2024
13e00fb
fixup
AbeJellinek Nov 15, 2024
874b6c5
Support up/down resizing
AbeJellinek Nov 15, 2024
75c381d
Skip history when bringing annotation into view
AbeJellinek Nov 15, 2024
534db05
Only navigate if needed
AbeJellinek Nov 15, 2024
1be7418
Hide annotation popup on keyboard resize
AbeJellinek Nov 21, 2024
2875fb0
Show selected annotation popup on Enter
AbeJellinek Nov 21, 2024
ec5e902
Prevent click from focusing annotations
AbeJellinek Nov 21, 2024
8a315ff
Tab out when annotation is selected
AbeJellinek Nov 21, 2024
4095998
Open note annotation popup after creation
AbeJellinek Nov 21, 2024
f16e1c4
Abort if annotation isn't in view
AbeJellinek Dec 6, 2024
43ed28a
Un-break note annotation dragging
AbeJellinek Dec 6, 2024
7159151
EPUB: Potentially prevent invalid annotations
AbeJellinek Dec 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Un-break note annotation dragging
  • Loading branch information
AbeJellinek committed Dec 6, 2024
commit 43ed28af0957fd99767f33c0615a9507f1bb1da8
1 change: 0 additions & 1 deletion src/dom/common/components/overlay/annotation-overlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,6 @@ let CommentIcon = React.forwardRef<SVGSVGElement, CommentIconProps>((props, ref)
height={size}
className="needs-pointer-events"
tabIndex={props.tabIndex}
onPointerDown={e => e.preventDefault()}
data-annotation-id={props.annotation?.id}
>
<div
Expand Down