Make SimpleVocabulary.fromItems() accept triples to assign titles #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #18 Some other vocabulary fixes while I was in there: - Make TreeVocubalary.fromDict only actually assign titles when a title is given. This makes it consistent with SimpleVocubalary.fromItems(). - Give equality and hash methods to SimpleTerm and SimpleVocubalary. This was a confusing stumbling block in the implementation of #51.
tseaver
approved these changes
Sep 2, 2018
|
Thanks! |
mgorny
added a commit
to mgorny/zope.schema
that referenced
this pull request
Sep 13, 2025
The runtime dependency on `setuptools` was only required for namespace support. Since `pkg_resources`-style namespaces have been removed in zopefoundation#52 and there are no relevant imports left in the code, remove the unnecessary dependency. Signed-off-by: Michał Górny <mgorny@gentoo.org>
8 tasks
icemac
pushed a commit
that referenced
this pull request
Sep 15, 2025
The runtime dependency on `setuptools` was only required for namespace support. Since `pkg_resources`-style namespaces have been removed in #52 and there are no relevant imports left in the code, remove the unnecessary dependency. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Some other vocabulary fixes while I was in there:
Make TreeVocubalary.fromDict only actually assign titles when a title is given. This makes it consistent with
SimpleVocubalary.fromItems()and make more sense IMO. There were no tests for this, so I added some.Give equality and hash methods to
SimpleTermandSimpleVocubalary.This was a confusing stumbling block in the implementation of Include a field's interface in equality and hashing. #51.