-
Notifications
You must be signed in to change notification settings - Fork 74
Make @implementer and classImplements not add redundant interfaces #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Latest commits make plone's buildout.coredev green for me. Currently based on #202. |
…aces. classImplementsOnly and @implementer_only can still be used to do that.
…ip the redundancy detection for the sake of plone.app.caching.
…ent. Seen in plone.app.testing as a problem in Products.GenericSetup. Added tests for that.
Rebased on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
new_declared.append(b) | ||
seen.add(b) | ||
for l in before, spec.declared, after: | ||
for b in l: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does pylint not complain about using lowercase-ell as a variable name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. |
The plone buildout.coredev tests all pass, with the exception of 8 tests from
plone.app.caching.tests.test_etags
. They all fail like this:That's with code like this:
Something is going wrong with
@implementer(Interface)
...