Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): 🌟 add support for React Native 0.73 #780

Closed
wants to merge 1 commit into from

Conversation

ngocle2497
Copy link

Summary

Starting from React Native v0.73 , all libraries will need to be updated with these two one-liners due to Android Gradle Plugin upgrade
discussions-671

Compatibility

OS Implemented
iOS
Android

@ngocle2497 ngocle2497 requested a review from zoontek as a code owner June 19, 2023 09:40
@ngocle2497 ngocle2497 changed the title feat(android): add change required for RN 0.73 feat(android): 🌟 add support for React Native 0.73 Jun 19, 2023
@zoontek
Copy link
Owner

zoontek commented Jun 19, 2023

@MasonLe2497 This library currently supports RN 0.63+, will it work for such a wide ranger of versions?

@ngocle2497
Copy link
Author

I tested on RN 0.71. It's work. I will try with RN 0.63 tomorrow

@ngocle2497 ngocle2497 force-pushed the master branch 2 times, most recently from 259e214 to 707a17f Compare June 21, 2023 03:19
@ngocle2497
Copy link
Author

ngocle2497 commented Jun 21, 2023

hey @zoontek , i updated my PR, now this library can support RN < 0.71 and RN >= 0.71 both

@zoontek
Copy link
Owner

zoontek commented Jun 24, 2023

@MasonLe2497 Thanks, but duplicate of #782
For the moment, I'd rather keep both without overhead. I think stripping the AndroidManifest namespace in the react native CLI, while autolinking could be the best option to keep compatibility for pre 0.71 without an additional warning.

@zoontek zoontek closed this Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants