Fixing 409 crashes #298
Merged
Fixing 409 crashes #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramanakumars
changed the title
Collaborator
Author
|
Changing the scope of this PR from removing the async saves to purely fixing the 409 error. I've added a reload to the subject set before it links the subjects. This should fix the "Stale resource" error. |
zwolf
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a few soft crashes with subject uploads, leading to the question of whether the async subject upload was causing issues. I've added a new non-asynchronous save method which appears to be more stable.
One other issue was when Panoptes would throw a
409: Attempted to update a stale object: SubjectSet.when updating subject sets with uploaded subjects. I've added a condition to the request to retry on a409error, which has fixed this issue.