Add GetTotalItems in CacheStorageInterface & GetBlockByHeightCacheFormat in Blocks Service #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukrawidhyawan
requested review from
andy-shi88,
astaphobia,
capt4ce and
iltoga
as code owners
astaphobia
approved these changes
Nov 11, 2020
iltoga
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on profiling when spam transaction, need to Implement more about blocks storage & add GetTotalItems to return the number of total items of storage. Change the type of
referenceBlockofGenerateReceipt, from*model.Blocksto*storage.BlockCacheObject.Breakdown
GetTotalItemsinCacheStorageInterfaceBlockServiceInterfacereferenceBlockGenerateReceiptto*storage.BlockCacheObjectReference Issue
Close #1340
Step to Test (optional)
run multiple local nodes