use BlocksStorage in mempool & optimeze validate request p2p #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukrawidhyawan
requested review from
andy-shi88,
astaphobia,
capt4ce and
iltoga
as code owners
andy-shi88
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Mempool Service, instead of using BlockStateStorage( storage get last blocks) is better to use BlocksStorage to get last block height only. On Validate Request P2P, reorder which one to check first based on the easiest on
oroperation.Breakdown
BlockStateStoragewith BlocksStorage on mempoolReference Issue
Close #numberIssue
Step to Test (optional)