add cache storage metrics #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaphobia
requested review from
capt4ce,
iltoga and
sukrawidhyawan
as code owners
iltoga
approved these changes
Sep 22, 2020
andy-shi88
reviewed
Sep 22, 2020
andy-shi88
approved these changes
Sep 22, 2020
capt4ce
reviewed
Sep 22, 2020
| @@ -270,6 +271,12 @@ func SetMonitoringActive(isActive bool) { | |||
| }, []string{"status"}) | |||
| prometheus.MustRegister(dbStatGaugeVector) | |||
|
|
|||
| // Cache Storage | |||
| cacheStorageCounter = prometheus.NewGaugeVec(prometheus.GaugeOpts{ | |||
| Name: "cache_storage_counter", | |||
There was a problem hiding this comment.
IMO it's better to prefix the name with zoobc_ so that we can easily find the metrics in grafana
| cacheStorageCounter = prometheus.NewGaugeVec(prometheus.GaugeOpts{ | ||
| Name: "cache_storage_counter", | ||
| Help: "Cache Storage counter", | ||
| }, []string{"mempools", "batch_receipts", "scramble_nodes", "backup_mempools", "node_shards"}) |
There was a problem hiding this comment.
IMO this is enough with 1 bucket []string{"storage_type"}
| @@ -270,6 +271,12 @@ func SetMonitoringActive(isActive bool) { | |||
| }, []string{"status"}) | |||
| prometheus.MustRegister(dbStatGaugeVector) | |||
|
|
|||
| // Cache Storage | |||
| cacheStorageCounter = prometheus.NewGaugeVec(prometheus.GaugeOpts{ | |||
There was a problem hiding this comment.
IMO better to name it cacheStorageGaugeVector to be able to understand it easily at a glance. what do you think?
Comment on lines
569
to
580
| switch cacheType { | ||
| case TypeMempoolCacheStorage: | ||
| cacheStorageCounter.WithLabelValues(string(cacheType)).Set(size) | ||
| case TypeBatchReceiptCacheStorage: | ||
| cacheStorageCounter.WithLabelValues(string(cacheType)).Set(size) | ||
| case TypeScrambleNodeCacheStorage: | ||
| cacheStorageCounter.WithLabelValues(string(cacheType)).Set(size) | ||
| case TypeMempoolBackupCacheStorage: | ||
| cacheStorageCounter.WithLabelValues(string(cacheType)).Set(size) | ||
| case TypeNodeShardCacheStorage: | ||
| cacheStorageCounter.WithLabelValues(string(cacheType)).Set(size) | ||
| } |
There was a problem hiding this comment.
I think we don't need this switch case. doing it cacheStorageCounter.WithLabelValues(string(cacheType)).Set(size) I think is enough
There was a problem hiding this comment.
ah, sorry. will update now
There was a problem hiding this comment.
already updated @capt4ce
sukrawidhyawan
approved these changes
Sep 22, 2020
capt4ce
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Need to add metrics part for cache storage, that will be cool in grafana dashboard.
Showing size in bytes.
Already in is: