Move batch receipt to cache storage #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaphobia
requested review from
andy-shi88,
capt4ce and
iltoga
as code owners
andy-shi88
approved these changes
Sep 18, 2020
capt4ce
reviewed
Sep 18, 2020
common/storage/batchReceipt.go
Outdated
| ) | ||
|
|
||
| if nItem, ok = item.(model.BatchReceipt); !ok { | ||
| return blocker.NewBlocker(blocker.ValidationErr, "invalid item") |
There was a problem hiding this comment.
I think this error should be more descriptive to ease debugging. making a phrase like "invalid batch receipt item"
sukrawidhyawan
approved these changes
Sep 18, 2020
andy-shi88
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better to move BatchReceipt to cache than save to database. Because there is no effect if the node restarts and batch reception has been lost.
Breakdown
Reference Issue
Close #1175