-
Notifications
You must be signed in to change notification settings - Fork 3
1139 initialize node addreress info cache #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andy-shi88
merged 14 commits into
zoobc:experimental
from
sukrawidhyawan:1139-Initialize-NodeAddreressInfo-Cache
Sep 18, 2020
Merged
1139 initialize node addreress info cache #1164
andy-shi88
merged 14 commits into
zoobc:experimental
from
sukrawidhyawan:1139-Initialize-NodeAddreressInfo-Cache
Sep 18, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Initialize-NodeAddreressInfo-Cache
…Initialize-NodeAddreressInfo-Cache
…Initialize-NodeAddreressInfo-Cache
andy-shi88
reviewed
Sep 18, 2020
capt4ce
approved these changes
Sep 18, 2020
…Initialize-NodeAddreressInfo-Cache
andy-shi88
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initialize Node Address Info Cache Storage. Move Some on Node Registry Service into Node Address Info Service.
Breakdown
NodeAddressInfoStorage
NodeAddressInfoStorage
onNodeAddressInfoService
NodeRegistrationService
intoNodeAddressInfoService
Reference Issue
Close #1139
Step to Test (optional)
Run multiple node-local,
Use API
GetNodeAddressesInfo
to see the cache of node address info