Sets minimum Perl version to v5.26.0 (Zonemaster-LDNS)#228
Merged
matsduf merged 1 commit intozonemaster:developfrom Jun 10, 2025
Merged
Sets minimum Perl version to v5.26.0 (Zonemaster-LDNS)#228matsduf merged 1 commit intozonemaster:developfrom
matsduf merged 1 commit intozonemaster:developfrom
Conversation
matsduf
requested review from
MichaelTimbert,
marc-vanderwal,
mattias-p,
tgreenx and
tolvmannen
matsduf
added
the
V-Major
marc-vanderwal
approved these changes
Jun 10, 2025
matsduf
changed the title
tgreenx
approved these changes
Jun 10, 2025
Contributor
I'd argue no. I think we can lower it to "minor" at most. |
tgreenx
added
V-Minor
Contributor
Author
I do not agree to "minor".
|
matsduf
added
V-Patch
matsduf
added
V-Major
Contributor
Author
|
Raised to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
zonemaster/zonemaster-cli#421 requires Perl version to be v5.26, and to meet that zonemaster/zonemaster#1387 documents lowest Perl version to be v5.26. To be consistent all Zonemaster Perl components should require the same minimum version.
This PR updates Makefile.PL to require v5.26.0, which makes
cpanmrefuse to install if the Perl version is lower.An alternative would be to add
use v5.26to all Zonemaster Perl modules.When (if) this PR is approved, RRs for the other components will be created.
To consider
Is this a breaking change? The version is not higher than the lowest version of Perl in the tested OSs in the last couple of releases.
Context
How to test this PR
Review. Try to install on a system with lower version of Perl (should fail) and another with that version of Perl or higher (should pass).