Update Zone11 implementation#1477
Conversation
aef34e0 to
84519a6
Compare
marc-vanderwal
left a comment
There was a problem hiding this comment.
Given that the domain-specific language in #1467 is merged, why not use that? It also supports replacing the root hints on the fly for subsequent scenarios.
|
@matsduf @marc-vanderwal thanks, I have updated the unit tests and this PR is now ready for review. In particular, see the handling of specific root hints for scenarios |
Have you considered using the model introduced in #1467 instead? |
Unfortunately no, just because I am not familiar with it yet and we are on a short deadline. I will start using it for next releases though ! |
matsduf
left a comment
There was a problem hiding this comment.
I would like to see standard unit test files before merge. Else this PR is fine.
84519a6 to
687cbc7
Compare
|
@matsduf @marc-vanderwal please re-review |
Purpose
This PR proposes an update of test case Zone11 implementation.
Context
Test case specification: zonemaster/zonemaster#1415
Test scenarios specification: zonemaster/zonemaster#1417
Changes
How to test this PR
Unit tests are updated and should pass.