Skip to content

Update Zone11 implementation#1477

Merged
tgreenx merged 1 commit intozonemaster:developfrom
tgreenx:update-zone11
Nov 14, 2025
Merged

Update Zone11 implementation#1477
tgreenx merged 1 commit intozonemaster:developfrom
tgreenx:update-zone11

Conversation

@tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Nov 4, 2025

Purpose

This PR proposes an update of test case Zone11 implementation.

Context

Test case specification: zonemaster/zonemaster#1415
Test scenarios specification: zonemaster/zonemaster#1417

Changes

  • Update implementation (test case, message tags, profile)
  • Update unit tests
  • Update unit test data

How to test this PR

Unit tests are updated and should pass.

@tgreenx tgreenx added this to the v2025.2 milestone Nov 4, 2025
@tgreenx tgreenx added A-TestCase Area: Test case specification or implementation of test case V-Patch Versioning: The change gives an update of patch in version. RC-Features Release category: Features. labels Nov 4, 2025
Copy link
Contributor

@marc-vanderwal marc-vanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the domain-specific language in #1467 is merged, why not use that? It also supports replacing the root hints on the fly for subsequent scenarios.

@tgreenx tgreenx marked this pull request as ready for review November 6, 2025 14:54
@tgreenx
Copy link
Contributor Author

tgreenx commented Nov 6, 2025

@matsduf @marc-vanderwal thanks, I have updated the unit tests and this PR is now ready for review. In particular, see the handling of specific root hints for scenarios NO-SPF-ROOT-ZONE, NULL-SPF-ROOT-ZONE, NON-NULL-SPF-ROOT-ZONE in t/Test-zone11.t where everything is in one file but requires a bit more code.

@matsduf
Copy link
Contributor

matsduf commented Nov 6, 2025

@matsduf @marc-vanderwal thanks, I have updated the unit tests and this PR is now ready for review. In particular, see the handling of specific root hints for scenarios NO-SPF-ROOT-ZONE, NULL-SPF-ROOT-ZONE, NON-NULL-SPF-ROOT-ZONE in t/Test-zone11.t where everything is in one file but requires a bit more code.

Have you considered using the model introduced in #1467 instead?

@tgreenx
Copy link
Contributor Author

tgreenx commented Nov 6, 2025

Given that the domain-specific language in #1467 is merged, why not use that? It also supports replacing the root hints on the fly for subsequent scenarios.

Have you considered using the model introduced in #1467 instead?

Unfortunately no, just because I am not familiar with it yet and we are on a short deadline. I will start using it for next releases though !

Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see standard unit test files before merge. Else this PR is fine.

@tgreenx
Copy link
Contributor Author

tgreenx commented Nov 13, 2025

@matsduf @marc-vanderwal please re-review

@tgreenx tgreenx merged commit 7dd4d09 into zonemaster:develop Nov 14, 2025
3 checks passed
@tgreenx tgreenx deleted the update-zone11 branch November 14, 2025 08:56
@tolvmannen tolvmannen added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Dec 8, 2025
@marc-vanderwal marc-vanderwal linked an issue Jan 8, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-TestCase Area: Test case specification or implementation of test case RC-Features Release category: Features. S-ReleaseTested Status: The PR has been successfully tested in release testing V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multiple SPF records

4 participants