Correctly set EDNS buffer size through 'edns_details'

[tgreenx]

Purpose

This PR proposes a fix to EDNS queries sent with edns_details (and without edns_details->size, so in test cases Nameserver{02, 10, 11, 12} which were not functioning properly - queries were sent but with an empty EDNS buffer size (0), so some name servers could not respond properly).

The cause seems that to be that setting the edns_size parameter to the underlying Zonemaster::LDNS resolver object isn't sufficient when Zonemaster::LDNS::query_with_pkt() is used. It bypasses the resolver-level properties, see ldns_resolver_send_pkt() vs ldns_resolver_send() - and in particular the omitted call to ldns_resolver_prepare_query_pkt(). We have to explicitly set it in the given Zonemaster::LDNS::Packet object.

Context

Fixes #1428

Changes

• Always set EDNS buffer size through edns_details

How to test this PR

This is not caught in current unit tests for several reasons:

• Lack of coverage (see Create unitary tests for Test Cases Nameserver{08,09,10,12,13,14} #1146)
• Most of those test cases output no message when there is no response on the initial EDNS SOA query, but also when everything is working fine

Manual testing (from #1428):

$ zonemaster-cli 131.193.130.in-addr.arpa --ns ns1.newroztelecom.com --ns ns2.newroztelecom.com --ns ns3.newroztelecom.com --ns ns4.newroztelecom.com --show-testcase --test nameserver02 --no-ipv6 --level info --raw
   0.00 INFO     Unspecified    GLOBAL_VERSION  version=v7.0.0
   0.67 INFO     Nameserver02   EDNS0_SUPPORT  ns_list=ns3.newroztelecom.com/95.170.204.172;ns4.newroztelecom.com/95.170.204.167;ns1.newroztelecom.com/93.91.200.200;ns2.newroztelecom.com/93.91.200.201

[mattias-p]

LGTM!