Skip to content

Corrects ASN lookup sources#1311

Merged
matsduf merged 1 commit intozonemaster:developfrom
matsduf:remove-cymru
Dec 11, 2023
Merged

Corrects ASN lookup sources#1311
matsduf merged 1 commit intozonemaster:developfrom
matsduf:remove-cymru

Conversation

@matsduf
Copy link
Contributor

@matsduf matsduf commented Dec 6, 2023

Purpose

Only the first element in the ASN source list is used.

How to test this PR

Read the text and verify that ASN lookup is used in a test.

@matsduf matsduf added this to the v2023.2 milestone Dec 6, 2023
@tgreenx
Copy link
Contributor

tgreenx commented Dec 7, 2023

Note that this PR is a consequence of a miss-implementation of the Zonemaster::Engine::ASNLookup function. It should be restored once it has been fixed.

@matsduf matsduf merged commit fda4f68 into zonemaster:develop Dec 11, 2023
@hannaeko hannaeko self-assigned this Jan 10, 2024
@hannaeko hannaeko added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Jan 10, 2024
@tgreenx
Copy link
Contributor

tgreenx commented May 16, 2024

Note that this PR is a consequence of a miss-implementation of the Zonemaster::Engine::ASNLookup function. It should be restored once it has been fixed.

Done in #1257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-ReleaseTested Status: The PR has been successfully tested in release testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants