Method to get name server names from undelegated data cache#1214
Method to get name server names from undelegated data cache#1214tgreenx merged 1 commit intozonemaster:developfrom
Conversation
marc-vanderwal
left a comment
There was a problem hiding this comment.
Looks good to me.
|
I do not see any issues of adding that code, since it is not used. What is the use case for the new method? The method only returns the name server names, not any addresses connected to those names. Is that not of interest too? |
There is already a method to fetch name servers addresses from the undelegated data cache ( This one is needed for this part in MethodsV2. It seems to be needed only once, and you can see its usage here. |
|
Now I see the usage for MethodsV2. |
Purpose
This PR proposes a new method to fetch name server names from the undelegated data cache.
Context
Necessary for #1050
Changes
get_fake_namesin Zonemaster::Engine::RecursorHow to test this PR