Merged
Conversation
Contributor
Author
|
@matsduf I noticed "rcode" value was passed to the message tag but not used, this is due to an oversight in the specification, but I took the liberty of adding it nonetheless since it is still given in the list of arguments. See https://github.com/zonemaster/zonemaster/blob/v2022.2.2/docs/specifications/tests/Zone-TP/zone09.md?plain=1#L115 EDIT: nevermind, there is already a PR to update the specification. zonemaster/zonemaster#1128 |
matsduf
reviewed
Mar 13, 2023
| push @results, info( Z09_UNEXPECTED_RCODE_MX => { | ||
| rcode => $rcode, | ||
| ns_ip_list => join( q{;}, sort $unexpected_rcode_mx{$rcode} ) | ||
| ns_ip_list => join( q{;}, sort @{ $unexpected_rcode_mx{$rcode} } ) |
Contributor
There was a problem hiding this comment.
Our current unit tests do not catch this type of errors. I do not say that we should add such tests to the unit tests, but we should be aware of it.
matsduf
previously approved these changes
Mar 13, 2023
matsduf
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR proposes a fix to a bug in Zone09. It also adds a missing return value in a message tag.
Context
Fixes #1210
Relates to zonemaster/zonemaster#1128
Changes
Z09_UNEXPECTED_RCODE_MXHow to test this PR