Skip to content

Remove duplicate function calls#420

Merged
tgreenx merged 1 commit intozonemaster:release-v2024.2.1from
tgreenx:remove-dup-calls
Feb 6, 2025
Merged

Remove duplicate function calls#420
tgreenx merged 1 commit intozonemaster:release-v2024.2.1from
tgreenx:remove-dup-calls

Conversation

@tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Feb 6, 2025

Purpose

This PR removes two duplicate function calls. The first calls are made several lines above. This looks like it was a mistake after a mixup between two commits: 72f1ec2 and 3985220 in release v2024.2.

How to test this PR

Tests should pass.
With manual testing, undelegated tests should still work:

$ zonemaster-cli --level INFO --ns ns2.nic.fr zonemaster.net --test basic --show-testcase --no-ipv6

Seconds Level    Testcase       Message
======= ======== ============== =======
   0.00 INFO     Unspecified    Using version v7.0.0 of the Zonemaster engine.
   0.00 INFO     Basic01        The zone "zonemaster.net" is found.
   0.00 INFO     Basic01        This is a test of an undelegated domain so finding the parent zone is disregarded.
   0.04 INFO     Basic02        Authoritative answer on SOA query for "zonemaster.net" is returned by name servers "ns2.nic.fr/192.93.0.4".
   0.04 INFO     Unspecified    Functional nameserver found. "A" query for www.zonemaster.net test skipped.

This looks like it was a mistake after a mixup between two commits: zonemaster@72f1ec2 and zonemaster@3985220.
@tgreenx tgreenx added the V-Patch Versioning: The change gives an update of patch in version. label Feb 6, 2025
@tgreenx tgreenx added this to the v2024.2.1 milestone Feb 6, 2025
@tgreenx tgreenx merged commit d17acbf into zonemaster:release-v2024.2.1 Feb 6, 2025
1 check passed
@tgreenx tgreenx deleted the remove-dup-calls branch February 6, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants